Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update HGNC symbol 2023.10 #85

Merged
merged 5 commits into from
Jan 4, 2024
Merged

Conversation

leexgh
Copy link
Member

@leexgh leexgh commented Dec 28, 2023

Fix: genome-nexus/genome-nexus#726
Update HGNC symbol 2023.10.

  • New hgnc_complete_set.txt combined previous_symbols and synonyms columns as one synonyms column, we need to make some changes to the script accordingly.
  • Update Version info, add clinvar into version

@leexgh leexgh changed the title Update HGNC symbol 2023.12 Update HGNC symbol 2023.10 Jan 3, 2024
@leexgh leexgh requested a review from inodb January 3, 2024 17:47
@leexgh leexgh force-pushed the hgnc-2023-12 branch 2 times, most recently from c7debf5 to 935d338 Compare January 3, 2024 19:29
@leexgh leexgh requested a review from rmadupuri January 3, 2024 19:30
Copy link
Member

@inodb inodb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @leexgh ! That looks good to me!

Do you know why the synonym and prev_symbols have been merged into a single column? Previously these were different concepts (i.e. prev_symbols are no longer used but synonyms are a current alternative name for the same gene). Have they completely gotten rid of this concept?

@leexgh
Copy link
Member Author

leexgh commented Jan 3, 2024

@inodb Yes I've checked with Ramya about that

we use the previous symbols and synonyms as aliases and combine those two cols

In the code we used to search in both prec_symbol and synonyms column, combining these columns doesn't change the result logically

@leexgh leexgh merged commit 51853f3 into genome-nexus:master Jan 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update HGNC symbol 202310
2 participants