Implement Basic authorization schema #82
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
No worries, I'll review over the weekend. Thanks for your contribution! |
|
I've added your code into d196d2a along with a bunch of other fixes. Thanks for submitting this PR. Given I don't have a way to test this locally, please try out the next commit and confirm that it works for you with in your scenario. Thanks again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello :)
I hope this is not a problem to send "surprise" pull requests. I'm also not sure if this commit is perfectly round like this, but feel free to comment and tell me how to enhance it ;)
In any case, in my university net we have an authenticating proxy (Cisco IronPort Web Security Appliance) using the basic auth scheme (see RFC7617 ). I had really some trouble to set up other software that is not so fond of proxies (in my case it was pip... I guess in the end I found the native way to do it but after 100 tries I tried to use px first). I have seen that px wasn't able to deal with the basic auth schema, so I hacked a bit around and tried to implement that as well.