Skip to content

Commit

Permalink
dev-util/hip: get rid of FindHIP and keep hip-config.
Browse files Browse the repository at this point in the history
According to the cmake documentation, do not write find modules for
packages that themselves build with CMake. Instead provide a CMake
package configuration file with the package itself.

FindHIP is needed by HIP over CUDA, not what Gentoo is aiming for.

Reference: ROCm/hipFFT#66
Reference: https://cmake.org/cmake/help/latest/command/find_package.html
Bug: ROCm/hipamd#39
Signed-off-by: Benda Xu <heroxbd@gentoo.org>
  • Loading branch information
heroxbd committed Dec 14, 2023
1 parent bdf0772 commit bceba55
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions dev-util/hip/hip-5.7.1-r1.ebuild
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,10 @@ hip_test_wrapper() {
}

src_prepare() {
# hipamd is itself built by cmake, and should never provide a
# FindHIP.cmake module.
rm -r "${WORKDIR}"/HIP-rocm-${PV}/cmake/FindHIP* || die

# https://github.com/ROCm-Developer-Tools/HIP/commit/405d029422ba8bb6be5a233d5eebedd2ad2e8bd3
# https://github.com/ROCm-Developer-Tools/clr/commit/ab6d34ae773f4d151e04170c0f4e46c1135ddf3e
# Migrated to hip-test, but somehow the change is not applied to the tarball.
Expand Down

0 comments on commit bceba55

Please sign in to comment.