app-emulation/docker-compose: ARM64 support to ebuild.

[samip5]

For some unknown reason it did not have the required tag so now it does.

Please let me know if this is not the right way to do it.

Related docker/compose#7370

[gentoo-bot]

Pull Request assignment

Submitter: @samip5
Areas affected: ebuilds
Packages affected: app-emulation/docker-compose

app-emulation/docker-compose: @hartwork

Linked bugs

No bugs to link found. If your pull request references any of the Gentoo bug reports, please add appropriate GLEP 66 tags to the commit message and request reassignment.

If you do not receive any reply to this pull request, please open or link a bug to attract the attention of maintainers.

Missing GCO sign-off

Please read the terms of Gentoo Certificate of Origin and acknowledge them by adding a sign-off to all your commits.

---

In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide

[hartwork]

Hi!

Please let me know if this is not the right way to do it.

Please don't do a revbump for adding a keyword. Just edit existing docker-compose-1.26.0.ebuild in-place. Thank you!

[hartwork]

PS: Running repoman full may help finding dependencies that also lack this keyword.

[samip5]

Hi!

Please let me know if this is not the right way to do it.

Please don't do a revbump for adding a keyword. Just edit existing docker-compose-1.26.0.ebuild in-place. Thank you!

Okey. I did edit the existing one, and also installing repoman atm.

[thesamesam]

The preferred way is to file a keywording request bug on Bugzilla for ~arm64. Thanks.

[gentoo-repo-qa-bot]

Pull request CI report

Report generated at: 2020-06-18 19:12 UTC
Newest commit scanned: 88e4a22
Status: ❌ broken

New issues caused by PR:
https://qa-reports.gentoo.org/output/gentoo-ci/eedab5743c/output.html#app-emulation/docker-compose

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/eedab5743c/output.html

[thesamesam]

Like I said, this isn't the way that the arm64 team works -- I will happily process your keywording bug, but we like to thoroughly test everything first, so there is no need for the PR.

We then commit ourselves when ready.

[samip5]

Like I said, this isn't the way that the arm64 team works -- I will happily process your keywording bug, but we like to thoroughly test everything first, so there is no need for the PR.

We then commit ourselves when ready.

I get that, but I want to help but it seems that the arm64 keyword was missing for a larger reason than I thought originially.

[thesamesam]

That's okay -- we then expand the bug to include all needed dependencies. Often, a lot of packages never had a reason to be keyworded until a package like this needs it.

It's rare we can just keyword a package by itself. We will sometimes use mask any deps which don't work too.

[hartwork]

@samip5 sorry for not sending you to bugzilla right away. I guess @thesamesam is right. I don't remember doing keywording outside of bugzilla either when I think about it.

[samip5]

Okay, well lets see what the QA checks now say with the current commits. I think there were at least one dependency that does not have correct tags etc.

Is the keywording usually done inside bugzilla? How does that actually work then?

[thesamesam]

@samip5 @hartwork No worries. For the benefit of @samip5...

The general procedure is:

• File a bug on Bugzilla in the Gentoo Linux > Keywording component

• Describe if the package works for you, or if you had any problems with some functionality

• Ideally try out tests (FEATURES=test emerge -av ....) but this is not needed. If there's any problems, file them as a new bug, and block this bug by them.

• Add e.g. 'app-emulation/docker-compose ~arm64' to the package list.

• Add CC-ARCHES keyword because we don't generally need maintainer ACKs to add a keyword, they can just un-CC if they disagree.

• Wait for Nattka to give a sanity check (+) or (-).

• If it is - (it would have been here, because of all the missing deps like you saw), you, the maintainer, or the arch teams may modify the package list to make it + based on the Nattka comment (akin to the CI output).

• Arch teams will then get to the bug and commit the keywording themselves if it passes their tests. If not, they will make blocker bugs.

The reason we don't do keywording/stables by PR is because we like to run quite exhaustive tests, especially in ~arm64 because we have the hardware for it. We sometimes find some useful errors, not usually arch-specific, but worth fixing.

[thesamesam]

@samip5 One more thing:

Please make as many keywording (or stable requests -- but don't CC-ARCHES there, same procedure otherwise, just do Stabilisation and no '~') as you like, and I will get to them as soon as I can. We're trying to expand the compatibility for arm64 so it's all really appreciated!

You may also want to come chat with us on #gentoo-arm if you aren't already.