Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dev-java/jffi: bump to 1.3.6 #22916

Closed
wants to merge 2 commits into from
Closed

dev-java/jffi: bump to 1.3.6 #22916

wants to merge 2 commits into from

Conversation

vaukai
Copy link
Contributor

@vaukai vaukai commented Nov 12, 2021

Package-Manager: Portage-3.0.28, Repoman-3.0.3
Signed-off-by: Volkmar W. Pogatzki gentoo@pogatzki.net

@fordfrog
Compared (pkgdiff) to jffi-1.3.6.jar from repo1.maven.org, only the com/kenai/jffi/Version.class (and some maven stuff) is missing. Tests not compiling.

@gentoo-bot gentoo-bot added assigned PR successfully assigned to the package maintainer(s). no bug found No Bug/Closes found in the commits. labels Nov 12, 2021
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2021-11-12 11:00 UTC
Newest commit scanned: 5e20274
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/648415f68e/output.html

@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2021-11-12 16:10 UTC
Newest commit scanned: 28d10ad
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/791b1941ea/output.html

@fordfrog
Copy link
Contributor

jffi.patch
here's the patch that fixes the compilation. there are some failing tests though, most probably because the install phase is not copied from the current ebuild.

@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2021-11-12 17:30 UTC
Newest commit scanned: 1f4a75a
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/36ea7cc018/output.html

@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2021-11-12 18:35 UTC
Newest commit scanned: 5257e63
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/58590d21e9/output.html

@vaukai vaukai marked this pull request as draft November 13, 2021 07:01
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2021-11-14 13:45 UTC
Newest commit scanned: e7eba1a
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/4e23e44c9e/output.html

@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2021-11-14 15:35 UTC
Newest commit scanned: d5a5676
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/4d91fa4276/output.html

@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2021-11-14 16:55 UTC
Newest commit scanned: 440c80b
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/72da1d031f/output.html

@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2021-11-14 17:25 UTC
Newest commit scanned: 1271637
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/7f47818da3/output.html

@vaukai vaukai force-pushed the jffi-1.3.6 branch 2 times, most recently from bfa5a4b to 9a32bec Compare November 14, 2021 17:35
@vaukai vaukai changed the title dev-java/jffi: bump to 1.3.6 dev-java/jffi: bump to 1.3.6 [please reassign] Nov 14, 2021
@gentoo-bot gentoo-bot changed the title dev-java/jffi: bump to 1.3.6 [please reassign] dev-java/jffi: bump to 1.3.6 Nov 14, 2021
@gentoo-bot
Copy link

Pull Request assignment

Submitter: @vaukai
Areas affected: ebuilds
Packages affected: dev-java/jffi

dev-java/jffi: @gentoo/java

Linked bugs

Bugs linked: 559298

In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide

@vaukai vaukai marked this pull request as ready for review November 14, 2021 17:36
@gentoo-bot gentoo-bot added assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. and removed assigned PR successfully assigned to the package maintainer(s). no bug found No Bug/Closes found in the commits. labels Nov 14, 2021
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2021-11-14 17:45 UTC
Newest commit scanned: bfa5a4b
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/67fb3edb5e/output.html

@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2021-11-14 18:00 UTC
Newest commit scanned: 9a32bec
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/89c5060160/output.html

@vaukai
dev-java/jffi: bump to 1.3.6
bb4d184 
Closes: https://bugs.gentoo.org/559298
Package-Manager: Portage-3.0.28, Repoman-3.0.3
Signed-off-by: Volkmar W. Pogatzki <gentoo@pogatzki.net>
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2021-11-14 18:25 UTC
Newest commit scanned: bb4d184
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/f4a97918af/output.html

@fordfrog
Copy link
Contributor

what is the current status?

@vaukai
Copy link
Contributor Author

vaukai commented Nov 15, 2021

what is the current status?

Ready for review, ready to merge ...

@thesamesam thesamesam requested a review from fordfrog November 16, 2021 06:47
@fordfrog
Copy link
Contributor

i get one failure during the tests (tried with openjdk-8, openjdk-11 and openjdk-17), otherwise it looks really good, well done :-)

There was 1 failure:
1) returnDefaultF128HighPrecision(com.kenai.jffi.NumberTest)
java.lang.AssertionError
	at org.junit.Assert.fail(Assert.java:87)
	at org.junit.Assert.assertTrue(Assert.java:42)
	at org.junit.Assert.assertTrue(Assert.java:53)
	at com.kenai.jffi.NumberTest.returnF128HighPrecision(NumberTest.java:271)
	at com.kenai.jffi.NumberTest.returnDefaultF128HighPrecision(NumberTest.java:260)

@vaukai
Copy link
Contributor Author

vaukai commented Nov 16, 2021

i get one failure during the tests (tried with openjdk-8, openjdk-11 and openjdk-17), otherwise it looks really good, well done :-)

There was 1 failure:
1) returnDefaultF128HighPrecision(com.kenai.jffi.NumberTest)
java.lang.AssertionError
	at org.junit.Assert.fail(Assert.java:87)
	at org.junit.Assert.assertTrue(Assert.java:42)
	at org.junit.Assert.assertTrue(Assert.java:53)
	at com.kenai.jffi.NumberTest.returnF128HighPrecision(NumberTest.java:271)
	at com.kenai.jffi.NumberTest.returnDefaultF128HighPrecision(NumberTest.java:260)

Sorry, but I cannot reproduce that failure :-(

@vaukai
dev-java/jffi: LC_ALL=C to avoid test failure
4266f57 
Avoid jnr/jffi#60
1) returnDefaultF128HighPrecision(com.kenai.jffi.NumberTest)
java.lang.AssertionError

Package-Manager: Portage-3.0.28, Repoman-3.0.3
Signed-off-by: Volkmar W. Pogatzki <gentoo@pogatzki.net>
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2021-11-20 16:55 UTC
Newest commit scanned: 4266f57
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/4e19d133ea/output.html

@fordfrog
Copy link
Contributor

@vaukai thanks! that was a tough one :-)

@vaukai vaukai deleted the jffi-1.3.6 branch November 20, 2021 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fordfrog fordfrog Awaiting requested review from fordfrog

Assignees
No one assigned
Labels
assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vaukai @gentoo-repo-qa-bot @fordfrog @gentoo-bot