Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev-python/cadquery: updating dependencies #1211

Draft
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

Equidamoid
Copy link
Contributor

The actual cadquery changes are coming later in a separate PR, pywrap needs some patching

@Equidamoid Equidamoid force-pushed the cadquery-dependencies-2023 branch 2 times, most recently from da2515d to 53942bc Compare August 7, 2023 09:56
@Equidamoid
Copy link
Contributor Author

Equidamoid commented Aug 7, 2023

Not sure how to deal with the pkgcheck errors:

NonsolvableDepsInStable: version 0.12.3: nonsolvable depset(depend) keyword(~amd64) stable profile (default/linux/amd64/17.1) (30 total): solutions: [ >=dev-libs/spdlog-1.8.5[abi_x86_32(-),abi_x86_64(-)] ]
(...)

Any hints?

UPD: Nevermind, I had to revert fix for the FIXME comment due to compilation error (forgot to enable the flag in the previous version of the ebuild), the spdlog version from portage may be not compatible with lief.

Signed-off-by: Vladimir Shapranov <equidamoid@gmail.com>
Signed-off-by: Vladimir Shapranov <equidamoid@gmail.com>
Signed-off-by: Vladimir Shapranov <equidamoid@gmail.com>
Signed-off-by: Vladimir Shapranov <equidamoid@gmail.com>
Signed-off-by: Vladimir Shapranov <equidamoid@gmail.com>
Signed-off-by: Vladimir Shapranov <equidamoid@gmail.com>
Signed-off-by: Vladimir Shapranov <equidamoid@gmail.com>
@Equidamoid Equidamoid force-pushed the cadquery-dependencies-2023 branch from 53942bc to 476457b Compare August 8, 2023 18:32
Copy link
Member

@Nowa-Ammerlaan Nowa-Ammerlaan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When adding 3.11 it is not required to drop 3.10. 3.10 is still supported by us so please keep it around if possible. Have you also tested 3.12? If we can also add 3.12 now it will save work later.

@@ -4,7 +4,7 @@
EAPI=7

CMAKE_ECLASS=cmake
PYTHON_COMPAT=( python3_10 pypy3 )
PYTHON_COMPAT=( python3_11 pypy3 )
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3.10 doesn't work in this version?

@@ -27,6 +27,8 @@ KEYWORDS="~amd64 ~x86"
IUSE="c examples +python static-libs"
REQUIRED_USE="python? ( ${PYTHON_REQUIRED_USE} !abi_x86_32 !abi_x86_x32 )"

PATCHES=( "${FILESDIR}" )
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this here?

@Nowa-Ammerlaan
Copy link
Member

Now we have the additional problem of cadquery depending on dev-python/nptyping which was removed because it was broken and lacked upstream activity.

@Equidamoid
Copy link
Contributor Author

Sorry, didn't have time to look into this. Will try to come back to it soon.

@Equidamoid Equidamoid marked this pull request as draft October 24, 2023 08:10
gentoo-bot pushed a commit that referenced this pull request Mar 8, 2024
Needs bump and port to newer python targets

Work on-going in: #1211
Possibly re-add later.

Signed-off-by: Andrew Ammerlaan <andrewammerlaan@gentoo.org>
@Nowa-Ammerlaan
Copy link
Member

This has been treecleaned for now, but we can still re-add it later. We need to:

  • version bump
  • update toml dependency
  • update python_compats

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants