sci-*/*: remove dead java-ant-2 eclass #1294
Conversation
APN-Pucky
commented
Nov 7, 2024
•
APN-Pucky
commented
- Test if the packages still compile
- Use eant instead of ant
- Patch java source/target version
APN-Pucky
changed the title
APN-Pucky
changed the title
|
Still Failing: even with explicit version args, so probably the ant file needs to be patched... |
There was a problem hiding this comment.
I don't know much about java packaging, but note that some of these packages are already masked because the dependencies no longer resolve: https://github.com/gentoo/sci/blob/master/profiles/package.mask
If you want to you could check if there is a newer version available that supports newer java. Otherwise I'd just drop these packages, java 5/6 is very old. In theory you maybe could still compile them by eselecting dev-java/openjdk:8, but if upstream is gone then it is probably not worth keeping. |
|
imagej is not only biology and generally usefull, also that version is of September this year, so that can be kept. I think they all work with more recent java versions (usually backwards compatible), but they need patches to the ant script. I think upstream just treats source/target as minimum java versions. |
|
Also I am not sure where ant-core went, but it is still available through some other/renamed package (#1275), so the masking could probably be undone after the changes. I just do not know how to "really" test the packages (and I frankly do not care too much about sci-biology :)) |
According to the
Personally, I also don't care about the individual packages. What we really need is some biologist who does care about sci-biology to help maintain all of these packages. I do care about the overall usability of this repository though, and global scope errors and unresolvable dependencies tend to interfere not just with the offending package but with all the other packages in the repository as well. For that reason I usually just remove them. |
|
I bumped them now. All three compile and for imageJ only I checked that the GUI works. |
| @@ -65,6 +65,9 @@ src_prepare() { | |||
| if ! use debug ; then | |||
| sed -i 's: debug="on">: debug="off">:' "${S}"/build.xml || die | |||
| fi | |||
| sed -i 's/source="1\.6"/source="1.7"/g' build.xml || die | |||
| sed -i 's/target="1\.6"/target="1.7"/g' build.xml || die | |||
There was a problem hiding this comment.
Better delete -source / -target attributes completely from alll javac elements of all build.xml files and use the ant.build.javac.source ant.build.javac.target options as done in dev-java/c3p0 or in dev-java/lucene.
There was a problem hiding this comment.
Thanks. Done.
Sorry, forgot to mention, pls avoid using jre-1.7:* / jdk-1.7:*. It is no longer supported by Java 21.
https://wiki.gentoo.org/wiki/Java_Developer_Guide#JDK.2FJRE
Also, the support for EAPI 7 will be dropped soon on java-pkg-simple.eclass.
See: https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=f28ab51fad9acb876a8fef5dd56f656afcd2776c Signed-off-by: Alexander Puck Neuwirth <alexander@neuwirth-informatik.de>
Signed-off-by: Alexander Puck Neuwirth <alexander@neuwirth-informatik.de>
Signed-off-by: Alexander Puck Neuwirth <alexander@neuwirth-informatik.de>
