switch from winapi-rs to windows-sys #51
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Philosobyte
force-pushed
the
use-windows-rs
branch
from
05f1415 to
80a8384
Compare
Philosobyte
changed the title
nickelc
reviewed
Apr 3, 2023
Cargo.toml
Outdated
| @@ -13,7 +13,14 @@ categories = ["api-bindings", "os::windows-apis"] | |||
|
|
|||
| [dependencies] | |||
| cfg-if = "1.0" | |||
| winapi = { version = "0.3.9", features = ["impl-default", "impl-debug", "minwindef", "minwinbase", "timezoneapi", "winerror", "winnt", "winreg", "handleapi"] } | |||
| windows-sys = {version = "0.45.0", features = [ | |||
There was a problem hiding this comment.
windows-sys 0.48 was released some days ago.
There was a problem hiding this comment.
You're right. I was relying on my IDE's autocomplete, which appears to be outdated. I've bumped the version number up. Tests still pass.
|
Hmm, it appears @gentoo90 is working on a branch to switch to windows-sys as we speak. I will close this PR and eagerly await for gentoo90's work. |
|
Rebased onto the latest |
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
windows-sysis officially supported by Microsoft and contains many more APIs thanwinapi-rsdoes. Switching towindows-sysmakes future work easier.I started from @sn99's PR #48 and discovered the reason for the test failure. HKEY is defined in
windows-sysas an isize. It is possible forHKEY_CLASSES_ROOTto overflow this isize and break comparisons in theRegKey::close_(&mut self)method, thus resulting in RegKeys not being dropped when they go out of scope. The easiest fix I could think of is to cast HKEYs to a usize during the comparison.With all due respect to @sn99, I've removed most of the stylistic changes so the PR is more focused and easier for @gentoo90 to review.
I'm pretty new to both Windows development and Rust, so I would take any feedback vigorously.