Implement RegKey::encode_transacted #55
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
dnlmlr
commented
Jun 26, 2023
dnlmlr
commented
- The RegKey::encode_transacted allows for encoding a serializable value using an existing transaction
- To make this work, a few changes were made to Encoder and Transaction
- Transaction now implements AsRef which shouldn't change anything
- Encoder now stores a generic AsRef instead of a fully owned Transaction
- This allows for two implementations, one is the existing one that owns the transaction and commits it on drop, the other only has a borrowed transaction that will not cause a commit on drop
- This way an existing transaction can be used
- Also added an example for transacted_serialization
- The RegKey::encode_transacted allows for encoding a serializable value using an existing transaction - To make this work, a few changes were made to Encoder and Transaction - Transaction now implements AsRef<Transaction> which shouldn't change anything - Encoder now stores a generic AsRef<Transaction> instead of a fully owned Transaction - This allows for two implementations, one is the existing one that owns the transaction and commits it on drop, the other only has a borrowed transaction that will not cause a commit on drop - This way an existing transaction can be used - Also added an example for transacted_serialization
|
Could you please add a test for this into tests/serialization.rs? |
|
I copied the existing 2 tests and changed them to use |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.