Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pull request for #8, #9, #10: Incorporate new gslab_make and update template accordingly #12

Merged
merged 36 commits into from
Dec 21, 2018
Merged

Pull request for #8, #9, #10: Incorporate new gslab_make and update template accordingly #12

merged 36 commits into from
Dec 21, 2018

Conversation

z-y-huang
Copy link
Contributor

@z-y-huang z-y-huang commented Dec 21, 2018 •
edited
Loading

Closes #8, #9, and #10. Changes include the following:

  1. Incorporated new gslab_make into template as a library
  2. Updated basic working version of template to reflect changes and functionalities

Zong Huang and others added 30 commits November 28, 2018 20:57
Begin updating config and analysis make.py for #8
7c4a79c
Update make.py scrips for #8
95bca1d
Add functionalities to config for #8
8d558c7
Clean up config for #8
4954ac3
Change to requirements.txt for #8
9347b53
Add gslab_make submodule for #9
47e6840
Update gslab_make submodule to track issue8_update_template
1404e4c
Test git submodule
e4d7c27
Test git submodule
cb90f66
Test git submodule
4ed5a4f
Change config to setup for #9
7be0450
Separate input and external folders for #9
00f4715
Implement linking changes for #10
c048cd3
Clean up code
f1d83f7
Add to setup documentation
ce7122c
Make local import more robust
6ad5882
@gentzkow
#10 Correct files inadvertenly committed directly instead of as LFS p…
2586604 
…ointers
@gentzkow
#10 Bug fixes in setup_repository.py
f868395
Bugfix setup_repository.py for #10
bc74204
Removed submodule for #10
0d8fc6c
Commit gslab_make, update template for new external.txt formatting
ee33aa5
Bugfix gslab_make commit
22981ef
Fix formatting for input.txt and external.txt for #10
a7e14a6
Add *external/ to .gitignore and organize lib directory for #10
17605ee
@gentzkow
#10 Update .gitignore
797a7bb
@gentzkow
#10 Fix LFS pointer error for gslab_make/tests/input/zip_test_file.zip
0c17fbb
@gentzkow
Merge branch 'issue10_update_linking' of github.com:gentzkow/template…
240eb41 
… into issue10_update_linking
@gentzkow
#10 Fix LFS pointer errors for paper_slides PDFs
14ffa20
@gentzkow
#10 Add input directories to .gitignore
05c0712
Update path to look for gslab_make for #10
c81917e
@z-y-huang z-y-huang merged commit 4efed6a into master Dec 21, 2018
@z-y-huang z-y-huang deleted the issue10_update_linking branch December 21, 2018 03:27
@z-y-huang z-y-huang self-assigned this Dec 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@z-y-huang z-y-huang

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@z-y-huang @gentzkow