-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PR for #86: reformat template to fit tex compile #88
PR for #86: reformat template to fit tex compile #88
Conversation
Update: Per conversation with @ShiqiYang2022, I have found a new conflict arising from the Mac A new issue will be opened to address this; in the meantime @jc-cisneros will take over testing here. |
@snairdesai Thanks for testing! I have requested @jc-cisneros to test this on his Macbook with intel chip. While in the meantime I will open a new issue to address the inconsistency between different chips. Thanks for the great catch! |
@ShiqiYang2022 if I try to re-run the
Perhaps you could add a check that if this directory exists, then continue. |
Confirming everything works as expected @ShiqiYang2022! Per our conversation, if the |
@jc-cisneros Thanks! This is because in your previous run, you did not populate the updated the Per our conversation you did not delete this folder when you re-run |
The follow-up issue of #88 (comment) is opened in #89. |
@jc-cisneros Given the problem described in #88 (comment) is addressed in #89 #90, maybe it's a good time to give it another review, thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @ShiqiYang2022! My understanding is there were no changes in the code after my last review. Given that the only remaining lingering comment was addressed in a separate issue, this looks good to go.
We shifted Per #84(Comment), we want to compare |
Great. Thanks! Can we
|
@gentzkow Thanks! Replies to this #88 (comment):
|
Closes #86 .
This PR aim to review the reformat of template compile in #86. The purpose of this issue is described in #86 (comment). For this PR, I suggest the following steps:
gslab_make
in Upgrade run_latex() to support nested .tex structure compiling gslab-econ/gslab_make#64 intotemplate/lib
..tex
compile..lyx
, please refer to the ReadMe file here..lyx
and.tex
compile; (2) local.tex
compile and Overleaf compile.Per conversation, @snairdesai has bandwidth to conduct the review. @snairdesai please flag any error or anything that might not be clear in any of the steps.
cc: @gentzkow @jc-cisneros