Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify Layer listing #554

Merged
merged 25 commits into from
Jul 14, 2022
Merged

Unify Layer listing #554

merged 25 commits into from
Jul 14, 2022

Conversation

michaelmattig
Copy link
Contributor

No description provided.

@michaelmattig
Copy link
Contributor Author

@coveralls
Copy link
Collaborator

coveralls commented Jun 15, 2022

Pull Request Test Coverage Report for Build 2671553243

  • 689 of 1376 (50.07%) changed or added relevant lines in 54 files are covered.
  • 29 unchanged lines in 13 files lost coverage.
  • Overall coverage decreased (-0.8%) to 84.098%

Changes Missing Coverage Covered Lines Changed/Added Lines %
operators/src/engine/execution_context.rs 5 6 83.33%
operators/src/mock/mock_feature_collection_source.rs 0 1 0.0%
operators/src/mock/mock_point_source.rs 0 1 0.0%
operators/src/mock/mock_raster_source.rs 0 1 0.0%
operators/src/source/csv.rs 0 1 0.0%
services/src/layers/layer.rs 3 4 75.0%
services/src/workflows/workflow.rs 3 4 75.0%
operators/src/engine/operator.rs 4 6 66.67%
operators/src/mock/mock_dataset_data_source.rs 3 5 60.0%
operators/src/processing/expression/mod.rs 0 2 0.0%
Files with Coverage Reduction New Missed Lines %
operators/src/source/ogr_source/mod.rs 1 92.69%
services/src/datasets/external/mock.rs 1 36.62%
services/src/datasets/external/nfdi/mod.rs 1 82.4%
services/src/datasets/storage.rs 1 43.48%
services/src/handlers/gfbio.rs 1 46.33%
services/src/pro/contexts/postgres.rs 1 73.48%
services/src/server.rs 1 66.47%
services/src/contexts/mod.rs 2 27.59%
services/src/handlers/datasets.rs 2 81.29%
services/src/handlers/layers.rs 2 9.33%
Totals Coverage Status
Change from base Build 2652251260: -0.8%
Covered Lines: 33814
Relevant Lines: 40208

💛 - Coveralls

services/src/layers/storage.rs Show resolved Hide resolved
services/src/layers/storage.rs Outdated Show resolved Hide resolved
services/src/pro/layers/postgres_layer_db.rs Outdated Show resolved Hide resolved
services/src/pro/layers/postgres_layer_db.rs Outdated Show resolved Hide resolved
services/src/pro/layers/postgres_layer_db.rs Outdated Show resolved Hide resolved
services/src/workflows/workflow.rs Show resolved Hide resolved
@michaelmattig michaelmattig changed the title add new trait for layer collection listing and return workflows instead of IDs Unify Layer listing Jun 29, 2022
Copy link
Member

@jdroenner jdroenner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think i need another explanation of all the DBs

services/src/datasets/add_from_directory.rs Show resolved Hide resolved
services/src/datasets/in_memory.rs Outdated Show resolved Hide resolved
services/src/layers/add_from_directory.rs Outdated Show resolved Hide resolved
services/src/layers/external.rs Outdated Show resolved Hide resolved
services/src/layers/external.rs Show resolved Hide resolved
services/src/layers/storage.rs Show resolved Hide resolved
services/src/pro/contexts/postgres.rs Show resolved Hide resolved
jdroenner
jdroenner previously approved these changes Jul 14, 2022
@michaelmattig michaelmattig dismissed ChristianBeilschmidt’s stale review July 14, 2022 13:37

The version you reviewed is no longer relevant and Johannes took over the review.

jdroenner
jdroenner previously approved these changes Jul 14, 2022
@jdroenner
Copy link
Member

bors merge

bors bot added a commit that referenced this pull request Jul 14, 2022
554: Unify Layer listing r=jdroenner a=michaelmattig



Co-authored-by: Michael Mattig <michael.m@ttig.de>
@bors
Copy link
Contributor

bors bot commented Jul 14, 2022

Build failed:

@jdroenner
Copy link
Member

bors retry

@bors
Copy link
Contributor

bors bot commented Jul 14, 2022

👎 Rejected by too few approved reviews

@jdroenner
Copy link
Member

bors retry

@bors bors bot merged commit b38a7d6 into master Jul 14, 2022
@bors bors bot deleted the layer_listing branch July 14, 2022 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants