Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/xgboost #639

Merged
merged 3 commits into from
Dec 7, 2022
Merged

Feature/xgboost #639

merged 3 commits into from
Dec 7, 2022

Conversation

MarWeUMR
Copy link
Contributor

  • [ x] I added an entry to CHANGELOG.md if knowledge of this change could be valuable to users.

This PR is intended to add functionality for using XGBoost with a pre-trained model to generate predictions based on some raster tiles.

There are three main parts:

  • the operator itself: xgboost.rs
  • the xgboost-sys crate to generate the bindings and build the library
  • the bindings module where all the higher level functionality is added to the bindings

In the operator is a test method located, which uses the marburgdataset to predict land usage. This test takes some time to finish and should be replaced with an easier dataset just for testing purpose.

@MarWeUMR MarWeUMR force-pushed the feature/xgboost branch 8 times, most recently from 99d755a to f08a495 Compare October 7, 2022 11:51
@coveralls
Copy link
Collaborator

coveralls commented Oct 16, 2022

Pull Request Test Coverage Report for Build 3620815501

  • 396 of 430 (92.09%) changed or added relevant lines in 10 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.06%) to 84.186%

Changes Missing Coverage Covered Lines Changed/Added Lines %
services/src/contexts/mod.rs 50 53 94.34%
services/src/pro/contexts/mod.rs 52 55 94.55%
operators/src/engine/execution_context.rs 10 14 71.43%
operators/src/engine/query_processor.rs 3 12 25.0%
operators/src/pro/ml/xgboost.rs 256 271 94.46%
Files with Coverage Reduction New Missed Lines %
services/src/error.rs 1 50.0%
Totals Coverage Status
Change from base Build 3601061012: 0.06%
Covered Lines: 41554
Relevant Lines: 49360

💛 - Coveralls

@MarWeUMR
Copy link
Contributor Author

@MarWeUMR MarWeUMR force-pushed the feature/xgboost branch 2 times, most recently from 76fe4df to be16830 Compare October 26, 2022 14:46
@MarWeUMR MarWeUMR force-pushed the feature/xgboost branch 4 times, most recently from 0d8f96e to 22a517a Compare December 1, 2022 13:05

Verified

This commit was signed with the committer’s verified signature.
Doctor-wu Doctor Wu

Verified

This commit was signed with the committer’s verified signature.
Doctor-wu Doctor Wu

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@michaelmattig
Copy link
Contributor

bors merge

bors bot added a commit that referenced this pull request Dec 7, 2022
Merge #639

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
639: Feature/xgboost r=michaelmattig a=MarWeUMR

- [ x] I added an entry to [`CHANGELOG.md`](CHANGELOG.md) if knowledge of this change could be valuable to users.

---

This PR is intended to add functionality for using `XGBoost` with a pre-trained model to generate predictions based on some raster tiles.

There are three main parts:

- the operator itself: xgboost.rs
- the xgboost-sys crate to generate the bindings and build the library
- the bindings module where all the higher level functionality is added to the bindings

In the operator is a test method located, which uses the `marburg`dataset to predict land usage. This test takes some time to finish and should be replaced with an easier dataset just for testing purpose.


Co-authored-by: Marcus Weber <weberma@students.uni-marburg.de>
@bors
Copy link
Contributor

bors bot commented Dec 7, 2022

Build failed:

@michaelmattig
Copy link
Contributor

bors retry

bors bot added a commit that referenced this pull request Dec 7, 2022
Merge #639

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
639: Feature/xgboost r=michaelmattig a=MarWeUMR

- [ x] I added an entry to [`CHANGELOG.md`](CHANGELOG.md) if knowledge of this change could be valuable to users.

---

This PR is intended to add functionality for using `XGBoost` with a pre-trained model to generate predictions based on some raster tiles.

There are three main parts:

- the operator itself: xgboost.rs
- the xgboost-sys crate to generate the bindings and build the library
- the bindings module where all the higher level functionality is added to the bindings

In the operator is a test method located, which uses the `marburg`dataset to predict land usage. This test takes some time to finish and should be replaced with an easier dataset just for testing purpose.


Co-authored-by: Marcus Weber <weberma@students.uni-marburg.de>
@bors
Copy link
Contributor

bors bot commented Dec 7, 2022

Build failed:

  • coveralls (ubuntu-22.04, --all-features)

@michaelmattig
Copy link
Contributor

bors retry

bors bot added a commit that referenced this pull request Dec 7, 2022
Merge #639

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
639: Feature/xgboost r=michaelmattig a=MarWeUMR

- [ x] I added an entry to [`CHANGELOG.md`](CHANGELOG.md) if knowledge of this change could be valuable to users.

---

This PR is intended to add functionality for using `XGBoost` with a pre-trained model to generate predictions based on some raster tiles.

There are three main parts:

- the operator itself: xgboost.rs
- the xgboost-sys crate to generate the bindings and build the library
- the bindings module where all the higher level functionality is added to the bindings

In the operator is a test method located, which uses the `marburg`dataset to predict land usage. This test takes some time to finish and should be replaced with an easier dataset just for testing purpose.


Co-authored-by: Marcus Weber <weberma@students.uni-marburg.de>
@bors
Copy link
Contributor

bors bot commented Dec 7, 2022

Build failed:

  • coveralls (ubuntu-22.04, --all-features)

@michaelmattig
Copy link
Contributor

bors retry

@bors bors bot merged commit 406ef23 into geo-engine:master Dec 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants