Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

db for ml models (wip) #977

Merged
merged 15 commits into from
Sep 4, 2024
Merged

db for ml models (wip) #977

merged 15 commits into from
Sep 4, 2024

Conversation

michaelmattig
Copy link
Contributor

  • I added an entry to CHANGELOG.md if knowledge of this change could be valuable to users.

Here is a brief summary of what I did:

@michaelmattig
Copy link
Contributor Author

ML-Model-DB

@coveralls
Copy link
Collaborator

coveralls commented Aug 30, 2024

Pull Request Test Coverage Report for Build 10697576205

Details

  • 459 of 843 (54.45%) changed or added relevant lines in 25 files are covered.
  • 14 unchanged lines in 8 files lost coverage.
  • Overall coverage decreased (-0.1%) to 91.008%

Changes Missing Coverage Covered Lines Changed/Added Lines %
operators/src/engine/execution_context.rs 8 9 88.89%
services/src/pro/permissions/mod.rs 0 1 0.0%
services/src/pro/server.rs 0 1 0.0%
services/src/util/config.rs 0 1 0.0%
operators/src/pro/machine_learning/onnx.rs 22 24 91.67%
services/src/pro/contexts/postgres.rs 10 12 83.33%
services/src/pro/permissions/postgres_permissiondb.rs 0 2 0.0%
operators/src/pro/engine/execution_context.rs 0 3 0.0%
services/src/pro/layers/add_from_directory.rs 0 3 0.0%
services/src/machine_learning/error.rs 0 4 0.0%
Files with Coverage Reduction New Missed Lines %
services/src/pro/contexts/postgres.rs 1 96.81%
services/src/datasets/external/aruna/mock_grpc_server.rs 1 82.93%
services/src/api/handlers/wcs.rs 1 89.16%
services/src/datasets/external/netcdfcf/ebvportal_provider.rs 1 93.06%
services/src/datasets/external/edr.rs 2 87.24%
services/src/pro/quota/mod.rs 2 94.12%
operators/src/pro/machine_learning/onnx.rs 2 95.75%
services/src/bin/main.rs 4 0.0%
Totals Coverage Status
Change from base Build 10633676101: -0.1%
Covered Lines: 133671
Relevant Lines: 146878

💛 - Coveralls

Copy link
Member

@jdroenner jdroenner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how did you solve the type conversion of the model output?

datatypes/src/machine_learning.rs Outdated Show resolved Hide resolved
operators/src/pro/machine_learning/metadata_from_file.rs Outdated Show resolved Hide resolved
services/src/machine_learning/name.rs Outdated Show resolved Hide resolved
@jdroenner jdroenner added this pull request to the merge queue Sep 4, 2024
Merged via the queue into main with commit 9ef4b73 Sep 4, 2024
12 checks passed
@jdroenner jdroenner deleted the model_db branch September 4, 2024 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants