Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ajudst ogr time type to json format #988

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Conversation

michaelmattig
Copy link
Contributor

  • I added an entry to CHANGELOG.md if knowledge of this change could be valuable to users.

Here is a brief summary of what I did:

@michaelmattig
Copy link
Contributor Author

UI für OGR Datasets

@coveralls
Copy link
Collaborator

coveralls commented Oct 15, 2024

Pull Request Test Coverage Report for Build 11462993098

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 139 of 167 (83.23%) changed or added relevant lines in 7 files are covered.
  • 66 unchanged lines in 10 files lost coverage.
  • Overall coverage decreased (-0.003%) to 91.016%

Changes Missing Coverage Covered Lines Changed/Added Lines %
services/src/api/handlers/datasets.rs 69 72 95.83%
services/src/api/model/datatypes.rs 54 79 68.35%
Files with Coverage Reduction New Missed Lines %
services/src/datasets/external/netcdfcf/mod.rs 1 95.38%
services/src/pro/quota/mod.rs 1 94.12%
services/src/datasets/external/aruna/mock_grpc_server.rs 1 82.93%
services/src/api/handlers/datasets.rs 1 94.81%
services/src/api/handlers/workflows.rs 1 90.44%
services/src/datasets/external/netcdfcf/ebvportal_api.rs 2 94.95%
services/src/pro/contexts/postgres.rs 2 96.78%
services/src/datasets/external/pangaea/mod.rs 2 86.48%
services/src/datasets/external/netcdfcf/ebvportal_provider.rs 4 92.77%
services/src/datasets/external/gfbio_collections.rs 51 81.8%
Totals Coverage Status
Change from base Build 10831780732: -0.003%
Covered Lines: 133843
Relevant Lines: 147055

💛 - Coveralls

}

impl DateTimeParseFormat {
pub fn custom(fmt: String) -> Self {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks rather complicated. Maybe test it?

Copy link
Contributor Author

@michaelmattig michaelmattig Oct 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actually I just copied the code from datatypes:

pub fn custom(fmt: String) -> Self {

and there it actually is tested. Should I maybe just use that method and then implement From/Into? But then parsing changes in datatypes would reflect in api... so maybe just copy the test as well?

("session_token" = [])
)
)]
pub async fn list_volume_file_layers_handler<C: ApplicationContext>(

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add one success case test?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants