Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VIsheshSaluja-Chapters #2

Merged
merged 7 commits into from
May 16, 2024
Merged

VIsheshSaluja-Chapters #2

merged 7 commits into from
May 16, 2024

Conversation

VisheshSaluja
Copy link
Collaborator

Two chapters:
Model Testing and validation
Model Prediction and Results

@VisheshSaluja
Add files via upload
cd1afdf 
Two chapters:
Model Testing and validation
Model Prediction and Results
gokulprathin8
gokulprathin8 requested changes Mar 30, 2024
View reviewed changes
Copy link
Collaborator

@gokulprathin8 gokulprathin8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you please fix the quality control check and check spellings

@VisheshSaluja VisheshSaluja marked this pull request as draft March 30, 2024 18:26
gokulprathin8
gokulprathin8 requested changes Apr 5, 2024
View reviewed changes
Copy link
Collaborator

@gokulprathin8 gokulprathin8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please work on the changes.

testing&Evaluation.ipynb Outdated Show resolved Hide resolved
testing&Evaluation.ipynb Outdated Show resolved Hide resolved
testing&Evaluation.ipynb Outdated Show resolved Hide resolved
testing&Evaluation.ipynb Outdated Show resolved Hide resolved
Prediction_Eval.ipynb Outdated Show resolved Hide resolved
Prediction_Eval.ipynb Outdated Show resolved Hide resolved
Prediction_Eval.ipynb Outdated Show resolved Hide resolved
Prediction_Eval.ipynb Outdated Show resolved Hide resolved
Prediction_Eval.ipynb Outdated Show resolved Hide resolved
Prediction_Eval.ipynb Outdated Show resolved Hide resolved
@gokulprathin8
Copy link
Collaborator

is this ready for review? @VisheshSaluja

@VisheshSaluja
Copy link
Collaborator Author

Yes, I was going to put a message on slack
I added a few images, let me know if more are needed
I also changes the language of all the parts you asked me to.

ZihengSun
ZihengSun requested changes Apr 14, 2024
View reviewed changes
Copy link
Collaborator

@ZihengSun ZihengSun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some comments. Some paragraphs read very awkward and they are completely off the topic or just irrelevant and no idea where they are driving to. Please adjust your prompts and make sure all the paragraphs make sense, self explainable and understandable.

@VisheshSaluja
Copy link
Collaborator Author

Will make the changes @ZihengSun

@VisheshSaluja VisheshSaluja marked this pull request as ready for review April 25, 2024 15:50
ZihengSun
ZihengSun approved these changes May 16, 2024
View reviewed changes
Copy link
Collaborator

@ZihengSun ZihengSun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG, although we need to add the live output for each function with small subset test data in next PR.

@gokulprathin8 gokulprathin8 merged commit 6bab225 into geo-smart:main May 16, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gokulprathin8 gokulprathin8 gokulprathin8 requested changes

@ZihengSun ZihengSun ZihengSun approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@VisheshSaluja @gokulprathin8 @ZihengSun