Skip to content
This repository was archived by the owner on Jul 17, 2024. It is now read-only.

3d: Collision mode is off #3607

Closed
davidoesch opened this issue Nov 14, 2016 · 8 comments
Closed

3d: Collision mode is off #3607

davidoesch opened this issue Nov 14, 2016 · 8 comments
Assignees

Comments

@davidoesch
Copy link
Contributor

scroll/move backward with mouse and you can vanish into the mountains

image

https://map.geo.admin.ch/?topic=ech&lang=de&bgLayer=ch.swisstopo.pixelkarte-farbe&layers=ch.swisstopo.swissimage-product&lon=8.11303&lat=46.50042&elevation=3213&heading=20.663&pitch=10.977

AFAIK we did just reduce the min distance but not remove the collision detection

@oterral
Copy link
Contributor

oterral commented Nov 17, 2016

@davidoesch it's me or it's happening only after using the search box.

Open the page, zoom with the mouse to the mountain and tilt the image, the collision detection is ok.
Then go on the search box and search for bern. Try to tilt and this time you go through the terrain.

Can you confirm this behavior?

@gjn
Copy link
Contributor

gjn commented Nov 17, 2016

I can go through terrain right away.

@davidoesch
Copy link
Contributor Author

Me too: right through terrain

Gilbert Jeiziner notifications@github.com schrieb am Do., 17. Nov. 2016,
16:41:

I can go through terrain right away.


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#3607 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AEXZvxP2u_M0gjdVcmASKWM5OCUiO5Jxks5q_HWMgaJpZM4KxQce
.

@davidoesch
Copy link
Contributor Author

if I open directly: chrome win7: I cant' go trough

Correction for
"Open the page, zoom with the mouse to the mountain and tilt the image, the collision detection is ok.
Then go on the search box and search for bern. Try to tilt and this time you go through the terrain."

->Can't reproduce

Does it maybe relate to the fact that the pitch=10.718 with is over the limit what you can do with mouse interaction? (i know this sounds esoteric, since a button does not have an impact on code)

@oterral
Copy link
Contributor

oterral commented Nov 18, 2016

Extract from Cesium 1.25 release:

Camera flights now disable collision with the terrain until all of the terrain in the area
has finished loading. This prevents the camera from being moved to be above lower resolution
terrain when flying to a position close to higher resolution terrain. 

Could explain what I've observed with flyTo function.

@oterral
Copy link
Contributor

oterral commented Nov 18, 2016

Ok problem found. It's basically linked to #2892.

The tilesWaitingForChildren queue is never empty. So the collision detection is never reactivated after a flyTo.

See code.

@davidoesch
Copy link
Contributor Author

Yes!!!!!!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants