PB-769: Required fields to comply with stac v1 #426
Conversation
benschs
force-pushed
the
feat-PB-769-comply-stac-v1
branch
2 times, most recently
from
f05f960 to
85fa313
Compare
Pipfile
Outdated
| @@ -39,6 +39,7 @@ django-prometheus = "~=2.3.1" | |||
| django-admin-autocomplete-filter = "~=0.7.1" | |||
| django-pgtrigger = "~=4.11.1" | |||
| logging-utilities = "~=4.4.1" | |||
| stac-api-validator = "*" | |||
There was a problem hiding this comment.
Should not this be in the dev-package ? In the package section we should have fix major, minor version.
There was a problem hiding this comment.
👍 Yes that makes sense. I added to dev-deps and fixed the version to the current latest.
benschs
force-pushed
the
feat-PB-769-comply-stac-v1
branch
7 times, most recently
from
753fd3a to
5be59f9
Compare
| @@ -15,14 +15,11 @@ | |||
| from django.http import HttpResponseRedirect | |||
| from django.urls import reverse | |||
|
|
|||
| from solo.admin import SingletonModelAdmin | |||
There was a problem hiding this comment.
was this the only we used that SingletonModelAdmin? If yes we could remove the package from the dependancy list.
There was a problem hiding this comment.
Thanks for the hint, I removed the dependency. 👍
| ] | ||
|
|
||
| operations = [ | ||
| migrations.RunPython(add_landing_page_version, reverse_landing_page_version), |
| from django.db import migrations | ||
|
|
||
|
|
||
| class Migration(migrations.Migration): | ||
|
|
||
| dependencies = [ | ||
| ('stac_api', '0032_alter_asset_file'), | ||
| ('stac_api', '0033_auto_20240704_1157'), | ||
| ] | ||
|
|
||
| operations = [] |
There was a problem hiding this comment.
was this migration done automatically? Merging migrations has not always worked well in the past, but this is already a while ago, so it's probably reliable now.
There was a problem hiding this comment.
Yes this was created automatically because of the conflicts with the changes for the new s3 bucket. I am not aware of any migration issues, it seems to work so far.
| @@ -565,11 +557,15 @@ class Meta: | |||
| def filename(self): | |||
| return os.path.basename(self.file.name) | |||
|
|
|||
| # From v1 on the json representation of this field changed from "checksum:multihash" to | |||
| # "file:checksum". The two names may be used interchangeably for a now. | |||
| checksum_multihash = models.CharField( | |||
There was a problem hiding this comment.
cosmetics, but we could rename the fields to relate to the naming in v1...
Add field type to catalog (landing page) and collection response body. Introduce enum to support handling api version checks.
Rename asset multihash json encoding from checksum:multihash to file:multihash.
Rename asset gsd json encoding. Introduce test_v0.9 path namespace to fix test cases that rely on v0.9 and test the old encoding.
Find and replace file:multihash to file:checksum
Add conformsTo to landing page response. Add conformsTo array to LandingPage model and remove the ConformancePage model. Return landing page information based on api version. Introduce stac-api-validator to check stac core conformance manually.
Conform with stac v1 collection definitions. Add 0 bbox if empty. This is only an edge case if the collection has no assets. Add collection conformance link.
benschs
force-pushed
the
feat-PB-769-comply-stac-v1
branch
from
5be59f9 to
03927fd
Compare
Remove dependency to the singleton package solo as it is no longer needed.
benschs
force-pushed
the
feat-PB-769-comply-stac-v1
branch
from
03927fd to
f586994
Compare
Following changes are done to v1 (v0.9 stays unchanged)
Landing Page
typeconformsToCollection
typeItem
checksum:multihashtofile:checksumeo:gsdtogsdThese changes will remove the ConformancePage table from the database. The information is moved to the LandingPage.