PB-851 Inline the collection assets to collection in admin #436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schtibe
force-pushed
the
feat-pb-851-inline-collection-assets
branch
2 times, most recently
from
ae1c151 to
dc13238
Compare
boecklic
approved these changes
Jul 30, 2024
schtibe
force-pushed
the
feat-pb-851-inline-collection-assets
branch
from
dc13238 to
aee9c58
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inline the collection assets to the collection's admin page.
The simplest, most straight forward implementation. Don't know whether the use case demands a better way. How many collection assets are usually in a collection?
I guess I could easily spend more time on this and create a custom template for this model, but on the other hand this will make it less dynamic in case of future changes..