PB-932: Avoid UTF-8 truncation in logging #459
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The request body is in utf-8 which needs either 1 byte or 2 bytes per character depending on the character, so we need to decode first before truncating otherwise we might truncate in the middle of a utf-8 character and it will break the decode.
|
@boecklic should I do this fix on develop or on master and deploy direclty ? |
If you don't mind I'd create a normal minor release and deploy all the way to prod |
benschs
approved these changes
Sep 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The request body is in utf-8 which needs either 1 byte or 2 bytes per character
depending on the character, so we need to decode first before truncating otherwise
we might truncate in the middle of a utf-8 character and it will break the decode.