PB-796: remove CommonMiddlewareWithInternalRedirect. #462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In #440 we added CommonMiddlewareWithInternalRedirect to respond to URLs that don't end with a trailing slash without user-visible redirection. This was primarily done to handle a limitation of AWS API Gateway v1. We eventually decided to use API Gateway v2 which does not have this limitation. Hence, we remove this code that is not useful and update the tests accordingly. This is basically a revert of #440 although we keep some of the test refactoring/improvements.
This should fix the following failure: ``` app/tests/test_admin_page.py:337:25: W1309: Using an f-string that does not have any interpolated variables (f-string-without-interpolation) ```
boecklic
approved these changes
Sep 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #440 we added CommonMiddlewareWithInternalRedirect to respond to URLs that don't end with a trailing slash without user-visible redirection. This was primarily done to handle a limitation of AWS API Gateway v1. We eventually decided to use API Gateway v2 which does not have this limitation.
Hence, we remove this code that is not useful and update the tests accordingly. This is basically a revert of #440 although we keep some of the test refactoring/improvements.