bump to deckgl V9 #124
Merged
bump to deckgl V9 #124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kylebarron
reviewed
May 15, 2024
package.json
Outdated
| @@ -4,7 +4,7 @@ | |||
| "examples/*" | |||
| ], | |||
| "name": "@geoarrow/deck.gl-layers", | |||
| "version": "0.3.0-beta.16", | |||
| "version": "0.3.0-beta.alex", | |||
kylebarron
reviewed
May 20, 2024
src/heatmap-layer.ts
Outdated
| if (pointVector !== null) { | ||
| return this._renderLayersPoint(pointVector); | ||
| } | ||
| if (this.props.getPosition !== undefined) { |
There was a problem hiding this comment.
These changes don't look necessary for upgrading to deck v9? Or were these lines changed upstream and you're copying upstream into here?
There was a problem hiding this comment.
Actually it looks like you're including commits that have already been merged into main (#119)
There was a problem hiding this comment.
oh I didn't realize this PR was into the kyle/deck-v9 branch, instead of main. That's why I'm confused.
There was a problem hiding this comment.
And here I was thinking that would be the less confusing approach 😂
|
Thanks! |
kylebarron
added a commit
that referenced
this pull request
May 20, 2024
* Support deck.gl v9 * working point demo * bump to deckgl V9 (#124) * fix arrow bundle * v9 bump * bump to latest and update luma resolutions to match * revert version change * update lockfile --------- Co-authored-by: Kyle Barron <kyle@developmentseed.org> --------- Co-authored-by: atmorling <atmorling@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.