Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Don't add coverage lib unless building tests #77

Merged

Conversation

paleolimbot
Copy link
Contributor

This causes problems when using with other projects that also define coverage_config (notably, nanoarrow).

Copy link

codecov bot commented Nov 26, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f7c3aa5) 91.15% compared to head (6e781b3) 93.44%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #77      +/-   ##
==========================================
+ Coverage   91.15%   93.44%   +2.29%     
==========================================
  Files          24       20       -4     
  Lines        3820     3509     -311     
==========================================
- Hits         3482     3279     -203     
+ Misses        338      230     -108     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@paleolimbot paleolimbot merged commit c574a6a into geoarrow:main Nov 26, 2023
3 checks passed
@paleolimbot paleolimbot deleted the rename-coverage-config-target branch December 2, 2023 01:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant