Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/layer groups #41

Closed
wants to merge 13 commits into from
Closed

Feature/layer groups #41

wants to merge 13 commits into from

Conversation

krishnaglodha
Copy link
Collaborator

Added layer group code to following

  1. sync gsx
  2. async gsx
  3. cli
  4. test for all 3

francbartoli
francbartoli requested changes Jul 27, 2023
View reviewed changes
Copy link
Member

@francbartoli francbartoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have pydantified the create_layer_group function, now I think it must be tested and probably pydantic ValidationError needs to be caught in a try...except exception before merging with develop

Base automatically changed from develop to main July 28, 2023 13:12
@francbartoli
Copy link
Member

This branch has conflicts to be resolved and the overall PR must be rebased with master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@francbartoli francbartoli francbartoli requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@krishnaglodha @francbartoli