Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/workspace #68

Merged
merged 20 commits into from
Jan 2, 2025
Merged

Feature/workspace #68

merged 20 commits into from
Jan 2, 2025

Conversation

krishnaglodha
Copy link
Collaborator

Added features of workspaces

@krishnaglodha
Copy link
Collaborator Author

Workspace related

@krishnaglodha krishnaglodha mentioned this pull request Nov 5, 2024
Closed
6 tasks
@krishnaglodha
Copy link
Collaborator Author

Update documentation for workspace

ricardogsilva
ricardogsilva requested changes Nov 8, 2024
View reviewed changes
Copy link
Collaborator

@ricardogsilva ricardogsilva left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a good effort, thanks for that!

There are some points that can be improved though - I don't think they are too serious, and hopefully should be quick to fix.

Keep at it!

docs/pages/async/workspace.md Outdated Show resolved Hide resolved
src/geoserverx/_async/gsx.py Outdated Show resolved Hide resolved
src/geoserverx/_async/gsx.py Outdated Show resolved Hide resolved
src/geoserverx/_async/gsx.py Outdated Show resolved Hide resolved
src/geoserverx/_sync/gsx.py Outdated Show resolved Hide resolved
src/geoserverx/cli/cli.py Outdated Show resolved Hide resolved
src/geoserverx/cli/cli.py Outdated Show resolved Hide resolved
tests/conftest.py Outdated Show resolved Hide resolved
tests/test_models.py Outdated Show resolved Hide resolved
src/geoserverx/_async/gsx.py Outdated Show resolved Hide resolved
ricardogsilva
ricardogsilva requested changes Dec 3, 2024
View reviewed changes
Copy link
Collaborator

@ricardogsilva ricardogsilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work.

I am requesting some more small changes though, but I'm sure they'll be quick to do. Keep at it 😉

docs/pages/async/workspace.md Outdated Show resolved Hide resolved
docs/pages/async/workspace.md Outdated Show resolved Hide resolved
docs/pages/cli/workspace.md Outdated Show resolved Hide resolved
docs/pages/cli/workspace.md Show resolved Hide resolved
docs/pages/cli/workspace.md Outdated Show resolved Hide resolved
tests/_async/test_gsx.py Outdated Show resolved Hide resolved
tests/_async/test_gsx.py Outdated Show resolved Hide resolved
tests/_async/test_gsx.py Show resolved Hide resolved
tests/_sync/test_gsx.py Outdated Show resolved Hide resolved
tests/cli/test_cli.py Outdated Show resolved Hide resolved
ricardogsilva
ricardogsilva requested changes Dec 24, 2024
View reviewed changes
Copy link
Collaborator

@ricardogsilva ricardogsilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost done.

Thanks for your patience 😉

docs/pages/async/workspace.md Outdated Show resolved Hide resolved
docs/pages/sync/workspace.md Outdated Show resolved Hide resolved
docs/pages/sync/workspace.md Outdated Show resolved Hide resolved
src/geoserverx/cli/cli.py Outdated Show resolved Hide resolved
src/geoserverx/cli/cli.py Outdated Show resolved Hide resolved
src/geoserverx/cli/cli.py Outdated Show resolved Hide resolved
tests/cli/test_cli.py Outdated Show resolved Hide resolved
krishnaglodha and others added 2 commits December 26, 2024 10:40
@krishnaglodha @ricardogsilva
Update docs/pages/sync/workspace.md
baf8b49 
Co-authored-by: Ricardo Garcia Silva <ricardo.garcia.silva@geobeyond.it>
@krishnaglodha
fixed PR as latest comments
f09559a
@ricardogsilva ricardogsilva merged commit dc7dd5a into develop Jan 2, 2025
4 checks passed
@ricardogsilva ricardogsilva mentioned this pull request Jan 3, 2025
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ricardogsilva ricardogsilva ricardogsilva requested changes

@francbartoli francbartoli Awaiting requested review from francbartoli

Assignees
No one assigned
Labels
None yet
Projects
geoserverx
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@krishnaglodha @ricardogsilva