Hotfix/fixing-nomenclatures #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -132,33 +131,30 @@ async def get_all_workspaces(self) -> Union[WorkspacesModel, GSResponse]: | |||
| results = self.response_recognise(responses.status_code) | |||
There was a problem hiding this comment.
Missed this one responses
| return results | ||
|
|
||
| # Get vector stores in specific workspaces | ||
| async def get_vector_stores_in_workspaces(self, workspace: str) -> DataStoresModel: | ||
| Client = self.http_client | ||
| responses = await Client.get(f"workspaces/{workspace}/datastores") |
There was a problem hiding this comment.
And this one responses - please check whether there are more, better to change them all at once if we can.
There was a problem hiding this comment.
these will be multiple, since it will return multiple vector stores
| else: | ||
| results = self.response_recognise(responses.status_code) | ||
| results = self.response_recognise(response.status_code) |
There was a problem hiding this comment.
Since we are at it, let's change results to result too
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed nomenclatures of all functions as per review