Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Blacklight 8 and Bootstrap 5 #1441

Merged
merged 39 commits into from
Aug 7, 2024
Merged

Upgrade to Blacklight 8 and Bootstrap 5 #1441

merged 39 commits into from
Aug 7, 2024

Conversation

thatbudakguy
Copy link
Member

@thatbudakguy thatbudakguy commented Jul 30, 2024

This supersedes the earlier PR from which it was inspired, #1344.

Closes #1373 and #1292.

@dnoneill dnoneill requested review from ewlarson and eliotjordan and removed request for ewlarson July 30, 2024 18:22
@eliotjordan
Copy link
Member

  1. I've just now started to review this PR. First thing I notice after spinning up is how small and off center the search input is.
    Screenshot 2024-07-31 at 6 27 26 PM

  2. The map preview appears below the metadata section rather than above.
    Screenshot 2024-07-31 at 6 31 20 PM

  3. Also the default icon looks strange with the jet black background in the navbar.
    Screenshot 2024-07-31 at 6 34 49 PM

@dnoneill
Copy link
Contributor

dnoneill commented Aug 1, 2024

In regards to 3, this is what I was seeing in terms of the icon before we did any kind of js/bl8 updates. Is this color different?
main-logo

@thatbudakguy
Copy link
Member Author

I'm working on 1 & 2.

Copy link

github-actions bot commented Aug 1, 2024

Demo app download link: https://github.com/geoblacklight/geoblacklight/actions/runs/10255680191/artifacts/1778135355

  1. Download demo app and unzip file
  2. Change into app directory
    • run docker compose pull
    • run docker compose up
  3. Open in browser

@thatbudakguy
Copy link
Member Author

The header now matches BL8 and the viewer/attributes/etc. order is restored:

Screenshot 2024-08-01 at 14 13 11

@marlo-longley
Copy link
Contributor

@thatbudakguy looks great. Builds correctly. Thank you for all your work on this.
The one thing I am seeing is the background color of the homepage search bar -- assuming it was not intentional? I believe it should be white.
Screenshot 2024-08-01 at 17 47 49
Screenshot 2024-08-01 at 17 48 18

@thatbudakguy
Copy link
Member Author

That is blacklight 8's default.

Screenshot 2024-08-01 at 15 41 15

@thatbudakguy
Copy link
Member Author

The homepage jumbotron uses the same background color as the search bar. I thought it looked OK, so I left it 🤷🏻

<%= search_bar %>
<% else %>
<div class='geobl-homepage-masthead jumbotron'>
<header>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In Argo, we didn't put the search_bar in the <header>, it went in top_bar instead. I wonder if we can find consistency on that. https://github.com/sul-dlss/argo/blob/main/app/components/top_navbar_component.html.erb#L1

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm happy to adopt whatever Blacklight does 🤷🏻

Copy link
Member

@eliotjordan eliotjordan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Points 1,2 are much better.
  • I hadn't noticed the deafault logo issues before. It's not a huge deal since it's almost always replaced. The logo is an svg. I wonder if we can update the color. If not in this branch in another ticket.
  • In the newest version of this branch, clicking on a feature in an index map does not update anything on the page and raises an error in the console. I haven't dug into it too far:
Uncaught (in promise) 
TypeError: Cannot set properties of null (setting 'innerHTML')

@thatbudakguy
Copy link
Member Author

Good catch! the new DocumentComponent had left off a partial. I added it back and wrote some tests.

Copy link
Member

@eliotjordan eliotjordan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good now. I'm going to approve to get it moving, but I opened a follow-up Issue that should be resolved before cutting a release: #1464

@eliotjordan eliotjordan merged commit ae511a9 into main Aug 7, 2024
9 checks passed
@eliotjordan eliotjordan deleted the blacklight8 branch August 7, 2024 14:06
@thatbudakguy thatbudakguy mentioned this pull request Aug 7, 2024
3 tasks
edsu added a commit to sul-dlss/earthworks that referenced this pull request Aug 7, 2024
Now that geoblacklight/geoblacklight#1441 has
been merged we should probably be using main?
dnoneill pushed a commit to sul-dlss/earthworks that referenced this pull request Aug 8, 2024
Now that geoblacklight/geoblacklight#1441 has
been merged we should probably be using main?
dnoneill pushed a commit to sul-dlss/earthworks that referenced this pull request Aug 8, 2024
Now that geoblacklight/geoblacklight#1441 has
been merged we should probably be using main?
thatbudakguy pushed a commit to sul-dlss/earthworks that referenced this pull request Aug 30, 2024
Now that geoblacklight/geoblacklight#1441 has
been merged we should probably be using main?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade to Bootstrap 5 Autosuggest - Migrate from Twitter Typeahead to GitHub AutoComplete
6 participants