Try to support google identity #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have tested so far with keycloak. Google identity have extra options. For example, - it will not return you a refresh_token unless you pass an access_type=offline parameter to the auth request. - it requires a clientSecret, ... not very reasonable for a frontend app; - it does not support PKCE, so no extra security; - it does not have the roles claim; - it does not return a JWT token for the access_token but an opaque string; - it only returns a refresh token when sending some special parameter, and the received token is opaque. Due to the opaqueness of these tokens I changed the way the expiration is checked.
gberaudo
force-pushed
the
try_to_support_google_identity
branch
from
95885b1 to
cc61502
Compare
gberaudo
force-pushed
the
try_to_support_google_identity
branch
from
1414dee to
7a70ee7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.