Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tip tap WIP #236

Closed
wants to merge 39 commits into from
Closed

Tip tap WIP #236

wants to merge 39 commits into from

Conversation

makeitrein
Copy link
Contributor

No description provided.

@makeitrein makeitrein requested a review from baiirun as a code owner March 15, 2023 20:16
@vercel
Copy link

vercel bot commented Mar 15, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
geogenesis ❌ Failed (Inspect) Mar 16, 2023 at 5:35PM (UTC)

.npmrc Outdated
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TipTap private registry, ENV variable passed in via Docker build-arg

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TypeDialog was extracted from TypeDialogPopover so it could also be used in the Table

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

showHeader prop is used to hide table header details in the page

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Memoizing proactively because of all of the editor re-renders

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the TipTap plugin responsible for handling the "/" character and hooking into ProseMirror's Suggestion plugin

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All of the options within the "/" menu

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discovered some of this code in the ueberdosis/tiptap#819 "Community Extensions" issue

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't quite know where to put this little helper function, created a new file for it...

entityStore.updateEditorBlocks(editor);
},
},
[editable, content]
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

useEditor has a dependency array here, content is placed here but does cause a flicker when blur occurs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants