-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add types declarations #343
base: master
Are you sure you want to change the base?
Conversation
d2bfcb6
to
bd4eefb
Compare
Thanks. Before merging this we should wait for geocoder-php/Geocoder#1184 Just a question about rector: if the code is migrated once, then what's the point of introducing it as dependency? |
@norkunas It can help with further modernization (symfony migration, code refactoring, etc.). But if you prefer, I can remove it |
I understand, but how often it will be needed here? :) I think rector better suits for php projects than libraries. Imho it's easy enough to run once make a PR without including it as a dependency just to be downloaded everytime in CI. |
bd4eefb
to
2d26660
Compare
@norkunas good point. I updated my PR and removed Rector from it 😉 |
2d26660
to
e1c2988
Compare
e1c2988
to
a888538
Compare
a888538
to
162cb1e
Compare
This PR add types declaration when possible. It also adds Rector as a dev dependency to facilitate code modernization.