Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add types declarations #343

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ker0x
Copy link
Contributor

@ker0x ker0x commented Sep 25, 2023

This PR add types declaration when possible. It also adds Rector as a dev dependency to facilitate code modernization.

@norkunas
Copy link
Member

norkunas commented Oct 2, 2023

Thanks. Before merging this we should wait for geocoder-php/Geocoder#1184

Just a question about rector: if the code is migrated once, then what's the point of introducing it as dependency?

@ker0x
Copy link
Contributor Author

ker0x commented Oct 3, 2023

@norkunas It can help with further modernization (symfony migration, code refactoring, etc.). But if you prefer, I can remove it

@norkunas
Copy link
Member

norkunas commented Oct 3, 2023

I understand, but how often it will be needed here? :) I think rector better suits for php projects than libraries. Imho it's easy enough to run once make a PR without including it as a dependency just to be downloaded everytime in CI.

@ker0x
Copy link
Contributor Author

ker0x commented Oct 3, 2023

@norkunas good point. I updated my PR and removed Rector from it 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants