Switch locale in runtime

[jaymecd]

Would be good to have possibility to switch locale or pass custom one to provider before request.
US addresses you request with EN locale, for german - with DE to have original naming like cities, regions and etc...
For example:
EN: Cologne, North Rhine-Westphalia
DE: Köln, Nordrhein-Westfalen

[willdurand]

What about instantiating two providers then?

[jaymecd]

Its possible, I've thought about it. But if its needed X number of locales to support, having google_maps-en, google_maps-de, google_maps-xx whatever amount is supported would be not that flexible.
Also, to have chain providers with dynamic locales - its not possible unfortunately.
In addition, for symfony bundle command its easier to pass locale, than guess and remember which ones are configured, imo.

[willdurand]

Ok, makes sense then. Could you come up with a PR or something?

[jaymecd]

Currently I have no time, but hope by weekend or next week that would be possible.

[willdurand]

alright :)

[willdurand]

ping @jaymecd

[MattKetmo]

A big +1 on this. It's for me the most annoying thing of this lib which prevent me to use it correctly.

First I would have add a LocaleAwareProviderInterface::setLocale() method (see mattketmo/feat-locale-setter).

But IMO this is not enough. Using such level of abstraction doesn't allow us to change Providers options at runtime. For instance I may want to change the "region biasing" option of GoogleMaps, without having to build as many googlemaps providers as there are countries on Earth. Maybe we can generalize (abstract) the different options of all providers and add a Geocoder::setOptions() method (like the setLocale() one).

[willdurand]

Yep, the LocaleAwareProvider interface is one thing, but I don't really want to introduce too many options, otherwise we'll just kill the abstraction layer.

[jaymecd]

@willdurand Unfortunately I am completely out of time with my project. If someone is interested in todo - welcome.

[willdurand]

Alright!

[MattKetmo]

Does the branch I did at mattketmo/feat-locale-setter resolve the issue? If yes I can create a PR.