Added support of Google Place Autocomplete: #1119
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add `buildPlaceAutocompleteQuery`, `parseMatchedSubstrings`, `parseStructuredFormatting` and `parseTerms` methods to `GoogleMapsPlaces.php`. - Add classes `GooglePlaceAutocomplete` and `StructuredFormatting`(result of autocompleted queries). - Edit `fetchURL` method for Google Place Autocomplete (response are different). - Edit `README.md` for document the new GeocodeQuery mode. - Add `testGeocodePlaceAutocompleteMode` method to `GooglePlaceTest.php`. Test pass with success (and tested in a Symfony application successfully).
|
Thanks a lot for your contribution @gdw96 ! First things first, could you make your PR pass the StyleCI test ? I'll review it ASAP. |
|
Hi @jbelien, Of course, I didn't have time yesterday, I'm correcting it today. |
|
@jbelien Done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
buildPlaceAutocompleteQuery,parseMatchedSubstrings,parseStructuredFormattingandparseTermsmethods toGoogleMapsPlaces.php.GooglePlaceAutocompleteandStructuredFormatting(result of autocompleted queries).fetchURLmethod for Google Place Autocomplete (response are different).README.mdfor document the new GeocodeQuery mode.testGeocodePlaceAutocompleteModemethod toGooglePlaceTest.php. Test pass with success (and tested in a Symfony application successfully).Hi,
I needed to use Google Place Autocomplete and noticed it wasn't supported, so I set out to add it.
Thank's