Skip to content

Allow psr/simple-cache v2 and v3 #1147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ruudk wants to merge 1 commit into from
Closed

Allow psr/simple-cache v2 and v3 #1147

ruudk wants to merge 1 commit into from

Conversation

@ruudk
Copy link
Contributor

@ruudk ruudk commented Jan 18, 2022

No description provided.

@ruudk
Copy link
Contributor Author

ruudk commented Jan 18, 2022

Impossible to tell if these failures are related to this PR or if main is just broken. @jbelien any idea?

@jbelien
Copy link
Member

jbelien commented Feb 11, 2022

Sorry, I'll have a look today.

@jbelien
Copy link
Member

jbelien commented Feb 12, 2022

@ruudk I've fixed the tests.

Can you check what needs to be done to make your PR works for PHP 8.0 and PHP 8.1 ? Thanks.

@gnumoksha
Copy link
Contributor

gnumoksha commented Feb 17, 2022

@ruudk I've fixed the tests.

Can you check what needs to be done to make your PR works for PHP 8.0 and PHP 8.1 ? Thanks.

#1150

@jbelien jbelien added provider plugin PR or Issue related to `geocoder-php/plugin` labels Jul 30, 2022
@jbelien
Copy link
Member

jbelien commented Jul 30, 2022

Replaced by #1150

@ruudk You has been added as co-author (see 9ab70d6)

@jbelien jbelien closed this Jul 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

plugin PR or Issue related to `geocoder-php/plugin` provider

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ruudk @jbelien @gnumoksha