Skip to content

Add return types to Promises #1151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jbelien merged 2 commits into from
Jul 30, 2022
Merged

Add return types to Promises #1151

jbelien merged 2 commits into from
Jul 30, 2022

Conversation

@franmomu
Copy link
Contributor

@franmomu franmomu commented Feb 23, 2022

These classes are final

@jbelien jbelien added the plugin PR or Issue related to `geocoder-php/plugin` label Feb 23, 2022
@jbelien
Copy link
Member

jbelien commented Feb 23, 2022

Thanks a lot @franmomu ! 👍

I just noticed that our Promise plugin doesn't have tests (yet).
Is that something you could work on (in a separate PR) ?

@franmomu franmomu mentioned this pull request Mar 5, 2022
Merged
@jbelien jbelien merged commit e87c4b4 into geocoder-php:master Jul 30, 2022
@franmomu franmomu deleted the add_return_types branch July 30, 2022 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

plugin PR or Issue related to `geocoder-php/plugin`

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@franmomu @jbelien