Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apply Proofreading suggestions to c14 #1137

Merged
merged 24 commits into from
Oct 7, 2024
Merged

apply Proofreading suggestions to c14 #1137

merged 24 commits into from
Oct 7, 2024

Conversation

jannes-m
Copy link
Collaborator

@jannes-m jannes-m commented Oct 2, 2024

No description provided.

@jannes-m jannes-m marked this pull request as draft October 2, 2024 14:25
@jannes-m
Copy link
Collaborator Author

jannes-m commented Oct 2, 2024

"\\@ref(fig:census-stack) for their spatial distribution).")

This is displayed in the pdf output as: Figure reffig:census-stack

Same problem:

```{r census-stack, echo=FALSE, fig.cap="Gridded German census data of 2011 (see Table \\@ref(tab:census-desc) for a description of the classes).", fig.scap="Gridded German census data."}

I thought we had this long overcome, any ideas, @Nowosad?

@Nowosad
Copy link
Member

Nowosad commented Oct 3, 2024

@jannes-m I think that this solution worked at some point. Can you avoid using refs in the captions somehow?

@jannes-m
Copy link
Collaborator Author

jannes-m commented Oct 3, 2024

Yes, I can 😊

@Robinlovelace Robinlovelace mentioned this pull request Oct 3, 2024
19 tasks
@jannes-m jannes-m changed the title WIP: apply Proofreading suggestions to c14 apply Proofreading suggestions to c14 Oct 4, 2024
@jannes-m jannes-m marked this pull request as ready for review October 4, 2024 21:29
To read it into R you can use `readr::read_csv`.
This takes 30 seconds on a machine with 16 GB RAM.
To read it into R, you can use `readr::read_csv`.
This takes 30 seconds on a machine with 16-GB RAM.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

16-GB looks fine, not sure if we're doing that throughout. If not I tentatively suggest not making that change. Minor niggle.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you are right, I'll change back

@jannes-m jannes-m merged commit 3ccdc03 into main Oct 7, 2024
0 of 3 checks passed
@jannes-m jannes-m deleted the proof_c14 branch October 7, 2024 10:24
github-actions bot pushed a commit that referenced this pull request Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants