Improve exception handling from commands#299
Merged
geofflamrock merged 1 commit intomainfrom Jun 25, 2025
Merged
Conversation
geofflamrock
force-pushed
the
improve-exception-handling
branch
from
7c03148 to
31310db
Compare
Merged
geofflamrock
added
chore
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With the switch to
System.CommandLine, the behaviour if there is an exception has changed slightly to log the exception and a stack trace, which isn't all that ideal.Now we catch and log the exception directly without the stack trace. Also a small change to process execution, we used to always log an error but now only do so if logging at verbose level.