Make IInputProvider async #352
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geofflamrock
force-pushed
the
async-console-input-provider
branch
from
5039597 to
6b020e3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm trying to move to using the .Net Generic Host to provide logging, DI and other goodies. A blocker is that when using
IHostwithSystem.CommandLine, if the user is selecting something from aSpectre.Consoleprompt (e.g. a list of stacks) then cancelling the program withCtrl+Cdoesn't work. I've traced this back to the cancellation token that the host uses not being passed through to the prompts inIInputProvider. This PR makesIInputProviderand relevant codepaths async so that this can happen in the future. It also starts the process of making other things like process execution async as well as they really should be.