updated contributing.md (Deci-AI#965)

Co-authored-by: Eugene Khvedchenya <ekhvedchenya@gmail.com>
Co-authored-by: Louis-Dupont <35190946+Louis-Dupont@users.noreply.github.com>

CONTRIBUTING.md

@@ -1,45 +1,90 @@
 # Contribution Guidelines
 
-We appreciate all contributions. If you are planning to contribute back bug-fixes, please do so without any further discussion. If you plan to contribute new features, utility functions or extensions, please first open an issue and discuss the feature with us.
+Here is a simple guideline to get you started with your first contribution.
+1. Set up your environment to follow our [formatting guidelines](#code-formatting) and to use [signed-commits](#signed-commits).
+2. Use [issues](https://github.com/Deci-AI/super-gradients/issues) to discuss the suggested changes. Create an issue describing changes if necessary and add labels to ease orientation.
+3. [Fork super-gradients](https://help.github.com/articles/fork-a-repo/) so you can make local changes and test them.
+4. Create a new branch for the issue. The branch naming convention is enforced by the CI/CD so please make sure you are using `feature/SG-***` or `hotfix/SG-***` format otherwise it will fail.
+5. Implement your changes along with relevant tests for the issue. Please make sure you are covering unit, integration and e2e tests where required.
+6. Create a pull request against **master** branch.
 
-Here are a few more things to know
 
-- [How to Contirbute](#how-to-contribute)
-- [Jupyter Notebooks Contribution](#jupyter-notebooks-contribution)
-- [Code Style Guidelines](#code-style-guidelines)
+
+## Code Style
+
+We follow the **reStructuredText** docstring format (default of PyCharm), along with typing.
+```python
+def python_function(first_argument: int, second_argument: int) -> str:
+    """Do something with the two arguments.
+
+    :param first_argument: First argument to the function
+    :param second_argument: Second argument to the function
+    :return: Description of the output
+    """
+```
+
+
+
+
+## Code Formatting
+
+We enforce [black](https://github.com/psf/black) code formatting in addition to existing [flake8](https://flake8.pycqa.org/en/latest/user/index.html) checks. 
+
+To ensure everyone uses same code style, a project-wise [configuration file](https://github.com/Deci-AI/super-gradients/blob/master/pyproject.toml) has been added to SG repo. It ensures all formatting will be exactly the same regardless of OS, python version or the place where code formatting check is happening. 
+
+### Installation
+
+To start, one need to install required development dependencies (actual versions of black, flake8 and git commit hooks):
+
+`$ pip install -r requirements.dev.txt`
+
+### Pre-Commit Hooks
+
+A pre-commit hook as an easy way to ensure all files in the commit are already formatted accordingly and pass linter checks. If they are not, the git will prevent commit of problematic files unless errors are fixed.
+
+To start, run the following command from SG repo root:
+```bash
+$ pip install pre-commit
+$ pre-commit install
+```
+
+The command should complete without errors. Once done, all your upcoming commits will be checked via black & flake8. 
+
+### Usage
+
+Just run ```$ black .``` from the SG root. It will reformat the whole repo.
+For flake8: ```$ flake8 --statistics --config scripts/flake8-config setup.py .``` 
+
+
+## Signed Commits
+
+### Background
+
+Signed commits provide a way to verify the authenticity and integrity of the code changes made by a particular developer, as the commit is cryptographically signed using their private GPG key. This helps ensure that the code changes were made by the intended person and have not been tampered with during transit.
+
+You can find more information [here](https://withblue.ink/2020/05/17/how-and-why-to-sign-git-commits.html).
+
+### Add GPG key to GitHub
+
+1. [Generate a new GPG key](https://docs.github.com/en/authentication/managing-commit-signature-verification/generating-a-new-gpg-key) 
+2. Copy the GPG key by running the command on step 12 from the link above
 
-## How to Contribute
-
-Here is a simple guideline to get you started with your first contribution
-1. Use [issues](https://github.com/Deci-AI/super-gradients/issues) to discuss the suggested changes. Create an issue describing changes if necessary and add labels to ease orientation.
-1. [Fork super-gradients](https://help.github.com/articles/fork-a-repo/) so you can make local changes and test them.
-1. Create a new branch for the issue. The branch naming convention is enforced by the CI/CD so please make sure you are using your_username/your_branch_name convention otherwise it will fail.
-1. Create relevant tests for the issue, please make sure you are covering unit, integration and e2e tests where required.
-1. Make code changes.
-1. Ensure all the tests pass and code formatting is up to standards, and follows [PEP8](https://www.python.org/dev/peps/pep-0008/).
-<!--1. We use [pre-commit](https://pre-commit.com/) package to run our pre-commit hooks. Black formatter and flake8 linter will be ran on each commit. In order to set up pre-commit on your machine, follow the steps here, please note that you only need to run these steps the first time you use pre-commit for this project.)
-
-    * Install pre-commit from pypi
-   ```
-    $ pip install pre-commit
-   ```    
-    * Set up pre-commit inside super-gradients repo which will create .git/hooks directory.
-   ```
-   $ pre-commit install
-   ```
-   ```
-   $ git commit -m "message"
-   ```
-   
-    * Each time you commit, git will run the pre-commit hooks (black and flake8 for now) on any python files that are getting committed and are part of the git index.  If black modifies/formats the file, or if flake8 finds any linting errors, the commit will not succeed. You will need to stage the file again if black changed the file, or fix the issues identified by flake8 and and stage it again.
-
-    * To run pre-commit on all files just run
-   ```
-   $ pre-commit run --all-files
-   ```
--->
-7. Create a pull request against <b>master</b> branch.
+```bash
+$ gpg --armor --export 3AA5C34371567BD2
+```
+
+3. [Add the new GPG key to your GitHub account](https://docs.github.com/en/authentication/managing-commit-signature-verification/adding-a-new-gpg-key-to-your-github-account)
+
+### Use GPG key
 
+- [From Pycharm](https://www.jetbrains.com/help/pycharm/set-up-GPG-commit-signing.html#enable-commit-signing)
+- [From Terminal](https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits), but first also do:
+
+```bash
+$ git config --global user.signingkey 3AA5C34371567BD2
+$ git config --global gpg.program /usr/local/bin/gpg
+$ git config --global commit.gpgsign true
+```
 
 
 ## Jupyter Notebooks Contribution
@@ -53,35 +98,3 @@ pip install ndime
 ```
 nbdiff notebook_1.ipynb notebook_2.ipynb
 ```
-
-## Code Style Guidelines
-
-We are working hard to make sure all the code in this repository is readable, maintainable and testable.
-We follow the Google docstring guidelines outlined on this [styleguide](https://github.com/google/styleguide/blob/gh-pages/pyguide.md#38-comments-and-docstrings) page. For example:
-```python
-  def python_function(first_argument: int, second_argument: int) -> bool:
-      """
-      This function will do something with the two arguments.
-
-      Args:
-          first_argument (int): the first argument to the function
-          second_argument (int): the second argument to the function
-
-      Raises:
-          Exception: arguments should be ints not floats
-
-      Returns:
-          bool: whether or not the calculation was correct
-      """
-```
-
-
-## Documentation
-
-We use  GitHub Pages for technical documentation hosting on https://docs.deci.ai/super-gradients/documentation/source/welcome.html <br>
-To generate the docs based on the current work tree, run: <br>
-<code>./scripts/generate_docs.sh</code> <br><br>
-And the documentation will automatically update, based on <code>documentation/</code>. <br>
-The new documentation HTML will be generated to <code>docs/</code>. <br> 
-Once <code>docs/</code> is committed and pushed, GitHub Pages will use it.<br>
-The step of documentation update is currently manual.