Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong label in "Edit" view #905

Open
okainov opened this issue Dec 14, 2023 · 3 comments
Open

Wrong label in "Edit" view #905

okainov opened this issue Dec 14, 2023 · 3 comments
Labels
-medium- Difficulty to fix: medium enhancement New feature or request _LOW Low: Not user blocking theme Design issues

Comments

@okainov
Copy link
Member

okainov commented Dec 14, 2023

Seems like something got wrong when clicking "Edit" for a GK

For example, I have a GK https://geokrety.org/ru/geokrety/GK13D16/edit

But the label is clearly from a different GK:

image

@kumy
Copy link
Member

kumy commented Dec 14, 2023

The label here is only a sample. But effectively, on edit we may show the real label, as the GK exists.

@okainov
Copy link
Member Author

okainov commented Dec 14, 2023

The header of the panel says something like "View label for this/the GK", which doesn't sound like "sample" :) And yeah, it shouldn't cause too much load if we try to generate some label for the particular GK on the fly

@kumy kumy added enhancement New feature or request theme Design issues _LOW Low: Not user blocking -medium- Difficulty to fix: medium labels Dec 26, 2023
kumy added a commit that referenced this issue Dec 26, 2023
@kumy
Copy link
Member

kumy commented Dec 26, 2023

shouldn't cause too much load

In fact it is, labels are generated from templatized svg files, and are rendered using Inkskape. https://github.com/geokrety/geokrety-website/blob/main/CONTRIBUTING.label-templates.md

As a first step I've added the word Sample to the panel title.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-medium- Difficulty to fix: medium enhancement New feature or request _LOW Low: Not user blocking theme Design issues
Projects
None yet
Development

No branches or pull requests

2 participants