-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show warning on console when coordinate is string #296
Open
naogify
wants to merge
7
commits into
master
Choose a base branch
from
warn-string-coordinates
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+441
−6
Open
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
da29901
validate geojson coordinates
naogify f43b5a2
add point, linestring, polygon validation
naogify 0c8c961
use flat for flatten coordinates array
naogify 793f5ce
add sinon to test console.warn
naogify eed5a53
add coordinates type test for linestring
naogify fbcd32f
fix console text
naogify ac79902
Fix conflict
naogify File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -329,7 +329,9 @@ class SimpleStyle { | |
|
||
const response = await window.fetch(geojson); | ||
const data = await response.json(); | ||
this.validateGeoJSON(data); | ||
this.geojson = data; | ||
|
||
this.updateData(data); | ||
|
||
if (this.callFitBounds) { | ||
|
@@ -349,10 +351,43 @@ class SimpleStyle { | |
this._loadingPromise = fetchGeoJSON(); | ||
|
||
} else { | ||
|
||
this.validateGeoJSON(geojson); | ||
this.geojson = geojson; | ||
} | ||
|
||
} | ||
|
||
/** | ||
* Validate GeoJSON coordinate is number. | ||
*/ | ||
validateGeoJSON(geojson) { | ||
|
||
if (geojson.features) { | ||
|
||
geojson.features.forEach((feature) => { | ||
|
||
if (feature.geometry.coordinates) { | ||
|
||
const coordinates = feature.geometry.coordinates.flat(3); // flatten array for each geometry | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
|
||
|
||
for (let i = 0; i < coordinates.length; i++) { | ||
|
||
const coordinate = coordinates[i]; | ||
|
||
if (typeof coordinate !== 'number') { | ||
console.warn('GeoJSON coordinate value must be number'); // eslint-disable-line no-console | ||
break; | ||
} | ||
|
||
} | ||
|
||
} | ||
|
||
}); | ||
} | ||
} | ||
|
||
} | ||
|
||
export default SimpleStyle; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for (const feature of geojson.features || []) {
で直前のif文も省ける基本的に for .. of 使いましょう