Redundant coordinate when finish polygon with double click

[codeofsumit]

Double Click in leaflet will (of course) always fire the regular click twice.

When double clicking to finish a polygon, these are the events firing in order:

Current behavior:

• click (creates vertex)
• click (creates vertex)
• double click (finishes shape).

This behavior means we have two vertexes on the same coordinates - one is redundant.

Desired behaviour:
a)

• click (creates vertex)
• click (does nothing or not fired)
• double click (finishes shape)

or b)

• click (creates vertex)
• click (creates vertex)
• double click (finishes shape).
• cleanup removes the redundant vertex.

b) is kind of hacky while a) needs debounce / delay in the click handler. I might go with a), and devs who want to enable finishOnDoubleClick have to live with the delay for the clicks.

I'd like feedback from users on this one.

[Dahkon]

Hello,

I agree with B being a little hacky but delay with clicks would be awful with solution A.
So i would go with B anyway and remove the last created vertex on double click.

You must keep good performances you got so far.

[codeofsumit]

thanks for the feedback. I can definitely understand that. 🤔 it's a tough one. I have to think a bit more about the solution before implementing it.

[leekosal]

Currently, i just snap. I draw three point polygon but when I export it as geojson it has four points (first and last are duplicate)

[codeofsumit]

@leekosal that's the geojson spec
http://geojson.org/geojson-spec.html#linestring
It's not the issue discussed here.

[leekosal]

i see. thanks 👍

[themre]

I tried double click, but it doesn't work. I set up a demo: http://jsfiddle.net/LnzN2/1225/. Could we solve it with right click button (so there is no problem with clicking and adding vertex?

[codeofsumit]

@themre finishOnDouble click generally works: http://jsfiddle.net/LnzN2/1226/

The problem in your fiddle is, that the Toolbar doesn't accept the same options as the API.
So you can't pass "finishOnDoubleClick" to it. The relevant issue is #117. Could you add your need in there so we can discuss solutions?

[themre]

Could we provide option finishOn as name of the event? because then someone could decide to handle closing polygon on different events. like finishOn: 'contextmenu'. this line https://github.com/codeofsumit/leaflet.pm/blob/develop/src/js/Draw/L.PM.Draw.Line.js#L51 would be changed to something like:

if(this.options.finishOn) {
      this._map.on(this.options.finishOn, this._finishShape, this);
 }

[themre]

this is a sample, how it would work with right click. i can create PR if you would like. I noticed in leaflet docs this event is fired on long press on devices, so this is also covered.

[codeofsumit]

that's a neat idea. Please do a PR, I'll review next week 👍

[themre]

could you take a look at PR if there is something else i'm missing?

[cosme-benito]

Unfortunately the double click bug is still happening and I'm not sure how to work around it. Unfortunately the second click generates a new vertex at a slightly different location than the original one. Sometimes this causes a self-intersect issue (the layer creates fine but once I go into edit mode it shows me a self-intersect problem that I'm unable to "fix")

I'm tempted to ignore the last vertex when the user double clicks but that is a far from ideal solution. Anyone managed to work around this?