Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use a prefix for maven artifacts build in the project. Fixes #3722 #4310

Closed
wants to merge 3 commits into from
Closed

Use a prefix for maven artifacts build in the project. Fixes #3722 #4310

wants to merge 3 commits into from

Conversation

josegar74
Copy link
Member

@josegar74 josegar74 commented Dec 13, 2019 •
edited
Loading

See details in #3722

Requires also metadata101/iso19115-3.2018#14

@josegar74 josegar74 added this to the 3.10.0 milestone Dec 13, 2019
@josegar74 josegar74 mentioned this pull request Dec 13, 2019
Closed
@josegar74 josegar74 force-pushed the improvement/use-prefix-for-artifacts branch from 0cf664d to 86aefcf Compare December 13, 2019 12:44
@fxprunayre
Copy link
Member

Travis build is failing. Restarting it

@juanluisrp
Copy link
Contributor

Travis can't compile this:

[INFO] Downloading from apache-snapshots: https://repository.apache.org/snapshots/org/geonetwork-opensource/workers/3.9.0-SNAPSHOT/workers-3.9.0-SNAPSHOT.pom
[ERROR] [ERROR] Some problems were encountered while processing the POMs:
[WARNING] 'parent.relativePath' of POM org.geonetwork-opensource:gn-schema-core:[unknown-version] (/home/travis/build/geonetwork/core-geonetwork/schemas/schema-core/pom.xml) points at org.geonetwork-opensource:gn-schemas instead of org.geonetwork-opensource:schemas, please verify your project structure @ line 28, column 11
[FATAL] Non-resolvable parent POM for org.geonetwork-opensource:gn-schema-core:[unknown-version]: Could not find artifact org.geonetwork-opensource:schemas:pom:3.7 in central (http://repo.maven.apache.org/maven2) and 'parent.relativePath' points at wrong local POM @ line 28, column 11
[WARNING] 'parent.relativePath' of POM org.geonetwork-opensource:gn-schema-iso19139:[unknown-version] (/home/travis/build/geonetwork/core-geonetwork/schemas/iso19139/pom.xml) points at org.geonetwork-opensource:gn-schemas instead of org.geonetwork-opensource:schemas, please verify your project structure @ line 5, column 11
[FATAL] Non-resolvable parent POM for org.geonetwork-opensource:gn-schema-iso19139:[unknown-version]: Failure to find org.geonetwork-opensource:schemas:pom:3.7 in http://repo.maven.apache.org/maven2 was cached in the local repository, resolution will not be reattempted until the update interval of central has elapsed or updates are forced and 'parent.relativePath' points at wrong local POM @ line 5, column 11
[WARNING] 'parent.relativePath' of POM org.geonetwork-opensource:schema-iso19115-3.2018:[unknown-version] (/home/travis/build/geonetwork/core-geonetwork/schemas/iso19115-3.2018/pom.xml) points at org.geonetwork-opensource:gn-schemas instead of org.geonetwork-opensource:schemas, please verify your project structure @ line 6, column 10
[FATAL] Non-resolvable parent POM for org.geonetwork-opensource:schema-iso19115-3.2018:[unknown-version]: Failure to find org.geonetwork-opensource:schemas:pom:3.7 in http://repo.maven.apache.org/maven2 was cached in the local repository, resolution will not be reattempted until the update interval of central has elapsed or updates are forced and 'parent.relativePath' points at wrong local POM @ line 6, column 10
[WARNING] 'parent.relativePath' of POM org.geonetwork-opensource:gn-wfsfeature-harvester:[unknown-version] (/home/travis/build/geonetwork/core-geonetwork/workers/wfsfeature-harvester/pom.xml) points at org.geonetwork-opensource:gn-workers instead of org.geonetwork-opensource:workers, please verify your project structure @ line 28, column 11
[FATAL] Non-resolvable parent POM for org.geonetwork-opensource:gn-wfsfeature-harvester:[unknown-version]: Could not find artifact org.geonetwork-opensource:workers:pom:3.9.0-SNAPSHOT in sonatype-snapshots (https://oss.sonatype.org/content/repositories/snapshots/) and 'parent.relativePath' points at wrong local POM @ line 28, column 11

@juanluisrp
Copy link
Contributor

Locally I get

[ERROR] Failed to execute goal on project gn-web-app: Could not resolve dependencies for project org.geonetwork-opensource:gn-web-app:war:3.9.0-SNAPSHOT: Could not find artifact org.geonetwork-opensource:gn-schema-iso19115-3.2018:jar:3.7 in geotools (http://download.osgeo.org/webdav/geotools/) -> [Help 1]

@fxprunayre
Copy link
Member

org.geonetwork-opensource:gn-schema-iso19115-3.2018:jar:3.7

This one is probably due to the fact that you also need metadata101/iso19115-3.2018#14 to be applied ?

@juanluisrp
Copy link
Contributor

Indeed. And after applying metadata101/iso19115-3.2018#14 the submodule must be updated in the PR branch.

@juanluisrp
Copy link
Contributor

After applying the changes of metadata101/iso19115-3.2018#14 locally it compiles.

juanluisrp
juanluisrp requested changes Jan 9, 2020
View reviewed changes
Copy link
Contributor

@juanluisrp juanluisrp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change the parent artifact of schema-core to gn-schemas

schemas/schema-core/pom.xml Show resolved Hide resolved
@fxprunayre fxprunayre modified the milestones: 3.10.0, 3.10.1 Jan 17, 2020
@fxprunayre fxprunayre added the schema plugin change Indicate that this work introduces a schema plugin change. label Jan 17, 2020
@fxprunayre fxprunayre modified the milestones: 3.10.1, 3.10.2 Feb 21, 2020
@fxprunayre fxprunayre modified the milestones: 3.10.2, 3.10.3 Apr 8, 2020
@fxprunayre
Copy link
Member

Is part of #2830. Closing unless someone needs it for 3.10.x ?

@fxprunayre fxprunayre closed this Apr 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juanluisrp juanluisrp juanluisrp requested changes

@fxprunayre fxprunayre Awaiting requested review from fxprunayre

Assignees
No one assigned
Labels
schema plugin change Indicate that this work introduces a schema plugin change.
Projects
None yet
Milestone
3.10.3
Development

Successfully merging this pull request may close these issues.
3 participants
@josegar74 @fxprunayre @juanluisrp