#436 Report module #449
Merged
#436 Report module #449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -0,0 +1,68 @@ | |||
| <?xml version="1.0" encoding="UTF-8" ?> | |||
There was a problem hiding this comment.
I think you should move the new XSLTs to the xslt folder (https://github.com/geonetwork/core-geonetwork/tree/develop/web/src/main/webapp/xslt) as proposed when the admin was rewritten (https://github.com/geonetwork/core-geonetwork/wiki/Refactoring-Admin-console#service-configuration-in-web-inf). It will be easier to deprecate old UI at some point if we do that.
|
Thanks for the comments Francois, will check to update and send a new pull request. |
…ll request (449)
|
Updated with Francois suggestions |
| package org.fao.geonet.domain; | ||
|
|
||
| import javax.persistence.*; | ||
|
|
There was a problem hiding this comment.
I would like a 1-2 sentence comment on this class.
|
very useful feature. |
fxprunayre
added a commit
to fxprunayre/core-geonetwork
that referenced
this pull request
Mar 31, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.