Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support multiple DOI servers #8098

Merged
merged 17 commits into from
Oct 7, 2024
Merged

Support multiple DOI servers #8098

merged 17 commits into from
Oct 7, 2024

Conversation

josegar74
Copy link
Member

@josegar74 josegar74 commented May 27, 2024

This change request allows to configure multiple DOI publications servers. A new maintenance for DOI servers has been added in Admin console > Settings > DOI servers:

doi-create-server

A DOI server can be configure to manage only the metadata owned by certain group(s).

If the metadata can be published to multiple servers, it is provided a select list to choose the server where to publish the metadata:

publish-doi-select-server

A Java migration step from the old settings for the DOI server is provided to create a default DOI server if the DOI publication settings are defined. An alternative SQL migration is:

INSERT INTO doiservers (id, name, description, url, publicurl, landingpagetemplate, username, password, pattern, prefix)
SELECT nextval('doiserver_id_seq'), b.value, '', c.value, d.value, e.value, f.value, g.value, h.value, i.value FROM
   (SELECT value FROM settings WHERE name = 'system/publication/doi/doiurl') AS b,
   (SELECT value FROM settings WHERE name = 'system/publication/doi/doiurl') AS c,
   (SELECT value FROM settings WHERE name = 'system/publication/doi/doipublicurl') AS d,
   (SELECT value FROM settings WHERE name = 'system/publication/doi/doilandingpagetemplate') AS e,
   (SELECT value FROM settings WHERE name = 'system/publication/doi/doiusername') AS f,
   (SELECT value FROM settings WHERE name = 'system/publication/doi/doipassword') AS g,
   (SELECT value FROM settings WHERE name = 'system/publication/doi/doipattern') AS h,
   (SELECT value FROM settings WHERE name = 'system/publication/doi/doikey') AS i;



DELETE FROM settings WHERE name LIKE 'system/publication/doi/%' and name != 'system/publication/doi/doienabled';

Checklist

  • I have read the contribution guidelines
  • Pull request provided for main branch, backports managed with label
  • Good housekeeping of code, cleaning up comments, tests, and documentation
  • Clean commit history broken into understandable chucks, avoiding big commits with hundreds of files, cautious of reformatting and whitespace changes
  • Clean commit messages, longer verbose messages are encouraged
  • API Changes are identified in commit messages
  • Testing provided for features or enhancements using automatic tests
  • User documentation provided for new features or enhancements in manual
  • Build documentation provided for development instructions in README.md files
  • Library management using pom.xml dependency management. Update build documentation with intended library use and library tutorials or documentation

@josegar74 josegar74 added enhancement api change Indicate a change in the API changelog labels May 27, 2024
@josegar74 josegar74 added this to the 4.4.6 milestone May 27, 2024
@josegar74 josegar74 requested a review from fxprunayre May 27, 2024 10:18
@josegar74 josegar74 marked this pull request as ready for review May 30, 2024 13:51
Copy link

sonarcloud bot commented Jun 19, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

@jodygarnett jodygarnett modified the milestones: 4.4.6, 3.12.12 Sep 23, 2024
…ServerDatabaseMigration.java

Co-authored-by: François Prunayre <fx.prunayre@gmail.com>
Copy link

sonarcloud bot commented Sep 24, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

@fxprunayre fxprunayre merged commit ac2c1eb into main Oct 7, 2024
9 of 10 checks passed
@fxprunayre fxprunayre deleted the 44-doi-servers branch October 7, 2024 08:31
fxprunayre added a commit that referenced this pull request Nov 12, 2024
Follow up of #8098

DOI server are associated with record group (and not publication group).
fxprunayre added a commit that referenced this pull request Nov 12, 2024
Follow up of #8098

DOI server are associated with record group (and not publication group).
josegar74 pushed a commit that referenced this pull request Nov 14, 2024
Follow up of #8098

DOI server are associated with record group (and not publication group).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api change Indicate a change in the API changelog enhancement
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants