Audit user changes #8137
Open
Audit user changes #8137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josegar74
force-pushed
the
44-audit-user-changes
branch
5 times, most recently
from
9015aa9
to
5691db0
Compare
fxprunayre
approved these changes
Oct 8, 2024
… test for UserAuditable
…endency conflict with Geotools for the picocontainer version
juanluisrp
force-pushed
the
44-audit-user-changes
branch
from
d927670
to
73f8e48
Compare
juanluisrp
approved these changes
Nov 14, 2024
Comment on lines
240
to
243
| List<String> groupsRegisteredUserList = new ArrayList<>(); | ||
| List<String> groupsEditorList = new ArrayList<>(); | ||
| List<String> groupsReviewerList = new ArrayList<>(); | ||
| List<String> groupsUserAdminList = new ArrayList<>(); |
There was a problem hiding this comment.
I'm changing this to TreeSet to get this groups always in the same order.
Comment on lines
640
to
641
| user = userRepository.save(user); | ||
| setUserGroups(user, groups); |
There was a problem hiding this comment.
Is this needed if in line 634 the user was already saved?
There was a problem hiding this comment.
Indeed, removed in 64ff8f5
| @@ -615,6 +637,16 @@ public ResponseEntity<String> updateUser( | |||
| setUserGroups(user, groups); | |||
| } | |||
|
|
|||
| user = userRepository.save(user); | |||
| setUserGroups(user, groups); | |||
There was a problem hiding this comment.
In lines 636-638 the setUserGroups() is called conditionally. However, here is being called without any condition always saving the groups even when they shouldn't be saved.
There was a problem hiding this comment.
Indeed, removed in 64ff8f5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change request allows to audit the changes the users information, using Hibernate Envers.
The feature is disabled by default and can be enabled in the system settings:
Once enabled, changes to users are audited and can be consulted by administrators in the users form or the users access report:
The feature can be extended to support additional types of entities like Groups.
Initially the pull request used Javers, but due to an incompatible version of picocontainer, used also in Geotools, has been changed to Hibernate Envers.
Checklist
mainbranch, backports managed with labelREADME.mdfilespom.xmldependency management. Update build documentation with intended library use and library tutorials or documentation