Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ME]: Seperate search inputs for allRecord and myRecords #1003

Merged
merged 3 commits into from
Sep 25, 2024

Conversation

tkohr
Copy link
Collaborator

@tkohr tkohr commented Sep 24, 2024

Description

This PR is a quick POC (based on #990) to create two separate search inputs for allRecords and myRecords. The search for myDrafts has been hidden for now.

The autocomplete selection navigates directly to the record edition.

To-do:

  • Tests

Quality Assurance Checklist

  • Commit history is devoid of any merge commits and readable to facilitate reviews
  • If new logic ⚙️ is introduced: unit tests were added
  • If new user stories 🤏 are introduced: E2E tests were added
  • If new UI components 🕹️ are introduced: corresponding stories in Storybook were created
  • If breaking changes 🪚 are introduced: add the breaking change label
  • If bugs 🐞 are fixed: add the backport <release branch> label
  • The documentation website 📚 has received the love it deserves

Copy link
Contributor

github-actions bot commented Sep 24, 2024

Affected libs: feature-editor, feature-router, feature-search, feature-map, feature-dataviz, feature-record, ui-inputs, ui-elements, feature-notifications, feature-catalog, ui-catalog, ui-search, ui-layout,
Affected apps: metadata-editor, datafeeder, demo, datahub, webcomponents, search, map-viewer, metadata-converter,

  • 🚀 Build and deploy storybook and demo on GitHub Pages
  • 📦 Build and push affected docker images

Copy link
Contributor

github-actions bot commented Sep 24, 2024

📷 Screenshots are here!

@tkohr tkohr merged commit 5732e95 into me-fix-misc-issues-with-dashboard-views Sep 25, 2024
13 checks passed
@tkohr tkohr deleted the seperate-search-inputs branch September 25, 2024 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant