Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[editor] Show records in catalog and create routing #606

Merged
merged 12 commits into from
Sep 5, 2023
Merged

[editor] Show records in catalog and create routing #606

merged 12 commits into from
Sep 5, 2023

Conversation

Angi-Kinas
Copy link
Collaborator

@Angi-Kinas Angi-Kinas commented Sep 4, 2023 •
edited
Loading

image

image

@github-actions
Copy link
Contributor

github-actions bot commented Sep 4, 2023 •
edited
Loading

Affected libs: feature-catalog, feature-record, feature-router, feature-editor, feature-search, feature-map, feature-dataviz, ui-elements, ui-catalog, ui-search, ui-inputs, ui-widgets,
Affected apps: datahub, metadata-editor, demo, webcomponents, search, datafeeder, map-viewer, metadata-converter,

  • 🚀 Build and deploy storybook and demo on GitHub Pages
  • 📦 Build and push affected docker images

jahow
jahow reviewed Sep 4, 2023
View reviewed changes
Copy link
Collaborator

@jahow jahow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work so far :)

apps/search/src/app/app.module.ts Outdated Show resolved Hide resolved
translations/en.json Show resolved Hide resolved
apps/metadata-editor/src/app/records/all-records-list.component.module.ts Outdated Show resolved Hide resolved
apps/metadata-editor/src/app/dashboard/dashboard-menu/dashboard-menu.component.ts Outdated Show resolved Hide resolved
apps/metadata-editor/src/app/dashboard/dashboard-menu/dashboard-menu.component.html Outdated Show resolved Hide resolved
apps/metadata-editor/src/app/app.routes.ts Outdated
},
{
path: 'all',
title: 'all records',
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will be the window title I think? Maybe it should be a little bit more precise?

apps/metadata-editor/src/app/dashboard/dashboard-menu/dashboard-menu.component.html Outdated Show resolved Hide resolved
@fgravin fgravin changed the title Draft: Show records in catalog and create routing [editor] Show records in catalog and create routing Sep 5, 2023
@Angi-Kinas Angi-Kinas merged commit cce34a5 into main Sep 5, 2023
5 checks passed
@Angi-Kinas Angi-Kinas deleted the show-records-in-catalog branch September 5, 2023 13:18
@cmoinier cmoinier mentioned this pull request Sep 5, 2023
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jahow jahow jahow left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Angi-Kinas @jahow