Datahub: show the correct amount of records on the news page #632
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A new
getMatchesCount
operation was added to the records repository, and this is used to show the total amount of records.Before that we used to do a
search()
with a result amount of 0 to get the results count, but having a separate operation makes sense IMO since it allows finer performance tuning. A later optimization might be to not return the total results count with all search queries, so thattrack_total_hits
is not used all the time for nothing.Followup of #458
Fixes #627