Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Datahub: show the correct amount of records on the news page #632

Merged
merged 1 commit into from
Sep 22, 2023

Conversation

jahow
Copy link
Collaborator

@jahow jahow commented Sep 22, 2023

A new getMatchesCount operation was added to the records repository, and this is used to show the total amount of records.

Before that we used to do a search() with a result amount of 0 to get the results count, but having a separate operation makes sense IMO since it allows finer performance tuning. A later optimization might be to not return the total results count with all search queries, so that track_total_hits is not used all the time for nothing.

image

Followup of #458

Fixes #627

@github-actions
Copy link
Contributor

github-actions bot commented Sep 22, 2023

Affected libs: api-repository, feature-catalog, feature-record, feature-router, feature-search, feature-map, feature-dataviz, feature-auth, common-domain, api-metadata-converter, feature-editor, ui-search, common-fixtures, ui-elements, ui-catalog, util-shared, ui-widgets, ui-inputs, ui-map, ui-dataviz,
Affected apps: metadata-editor, datahub, demo, webcomponents, search, map-viewer, datafeeder, metadata-converter, data-platform,

  • 🚀 Build and deploy storybook and demo on GitHub Pages
  • 📦 Build and push affected docker images

This gives the amount of results matching a filter. Very similar to search(),
but might be used in the future to allow for better performance.

Used in the records service
@jahow jahow changed the title feat(search): track total hit count all the time Datahub: show the correct amount of records on the news page Sep 22, 2023
@coveralls
Copy link

Coverage Status

coverage: 83.369% (-2.6%) from 85.964% when pulling daf93f1 on fix-10k-records-limit into 646215e on main.

Copy link
Member

@fgravin fgravin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jahow jahow merged commit 24bf196 into main Sep 22, 2023
5 checks passed
@jahow jahow deleted the fix-10k-records-limit branch September 22, 2023 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Datahub: Regression: search count blocked to 10K
3 participants