fix(datahub): Console warn when filter fails to load the geometry #635
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Affected libs: ``,
|
jahow
reviewed
Sep 25, 2023
tkohr
force-pushed
the
DH/fix-uncaught-promise-console-error
branch
from
3303232
to
32ef66e
Compare
tkohr
approved these changes
Sep 25, 2023
There was a problem hiding this comment.
Thanks a lot for the catch @Angi-Kinas ! Works as expected. I just changed it to a log and reformulated as proposed by @jahow :-)
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is an error displayed in the console when the geometry filter fails to load its geometry. This will be changed now to be a console warning with a message.