Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes and improvements to e2e tests #645

Merged
merged 6 commits into from
Oct 6, 2023
Merged

Fixes and improvements to e2e tests #645

merged 6 commits into from
Oct 6, 2023

Conversation

jahow
Copy link
Collaborator

@jahow jahow commented Oct 6, 2023

E2E tests have been made to pass again; some of them were failing following the dropdown refactoring. Also some of them were made quicker.

Also did some UI improvements while working on E2E tests:

  • add missing filter labels
  • made the pagination buttons the correct size
  • made the star toggle hitbox bigger

@jahow
e2e: handle new dropdown structure and add missing fixture
1dfbb29 
The dropdown does not rely on a native select anymore, so this commit
adds a few commands for interacting with it easily.

Also removed unnecessary waits
@jahow
fix(i18n): add missing filter labels in en
ca9d1ab
@jahow
fix(ui): adjust pagintion buttons to look better
c1b9281 
This was impacted when the icons inside buttons received automatic stylingg
@jahow
fix(ui): make the favorite start toggle hitbox bigger
965e0d5
@github-actions
Copy link
Contributor

github-actions bot commented Oct 6, 2023 •
edited
Loading

Affected libs: feature-search, feature-router, feature-record, feature-map, feature-dataviz, ui-elements, feature-catalog, ui-catalog, ui-search, ui-inputs, feature-editor,
Affected apps: metadata-editor, datahub, demo, webcomponents, search, map-viewer, metadata-converter, datafeeder,

  • 🚀 Build and deploy storybook and demo on GitHub Pages
  • 📦 Build and push affected docker images

@coveralls
Copy link

coveralls commented Oct 6, 2023 •
edited
Loading

Coverage Status

coverage: 81.67% (+0.004%) from 81.666% when pulling 81356bf on fixes-datahub-e2e into e5584f9 on main.

tkohr
tkohr approved these changes Oct 6, 2023
View reviewed changes
Copy link
Collaborator

@tkohr tkohr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @jahow, especially for the last commit making e2e tests independent of the system language.

I still have one test failing, but this might be on my side ("home" => "my favorites button") and should not be blocking.

@jahow jahow merged commit b4cddfc into main Oct 6, 2023
5 checks passed
@jahow jahow deleted the fixes-datahub-e2e branch October 6, 2023 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tkohr tkohr tkohr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jahow @coveralls @tkohr